Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing android package? #11

Closed
gbovyn opened this issue Apr 22, 2018 · 5 comments
Closed

Missing android package? #11

gbovyn opened this issue Apr 22, 2018 · 5 comments

Comments

@gbovyn
Copy link

gbovyn commented Apr 22, 2018

Hi, I tried to integrate flogger into a Liferay OSGi module but I get an error at deploy time:
Unresolved requirement: Import-Package: com.google.common.flogger.backend.android

I see a reference to this package (using Github search) here:
https://github.com/google/flogger/blob/master/api/proguard.cfg
here:
https://github.com/google/flogger/blob/master/api/src/main/java/com/google/common/flogger/backend/Platform.java
and here:
https://github.com/google/flogger/blob/1e2caa0b5b46b79377c5778be42b63f2ebc0655c/api/platformprovider/main/java/com/google/common/flogger/backend/PlatformProviderGenerator.java

but it doesn't seem to exist
https://github.com/google/flogger/tree/master/api/src/test/java/com/google/common/flogger/backend

Should it work without it?

@ronshapiro
Copy link
Contributor

It should work without it - we'll work on releasing those, but in the meantime 3794de6 should remove those instances

@gbovyn
Copy link
Author

gbovyn commented Apr 24, 2018

Thanks for your rapid answer. Is there a release planned for the changes added?

@ronshapiro
Copy link
Contributor

We would like to add automatic snapshot building on each commit, would that help?

In the interim, do you want to run release/install-local-snapshot.sh and switch your versions to LOCAL-SNAPSHOT to see if the issue is fixed?

@gbovyn
Copy link
Author

gbovyn commented Apr 24, 2018

Yes, it would be appreciated. Installing all bazel dependencies is a bit heavy to test one specific commit.

I am checking how I can work around Windows limitations to have it working, but there is no emergency on my side to test it out. It can wait that you have a stable CI system.

@hagbard
Copy link
Contributor

hagbard commented Dec 19, 2018

Was this resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants