-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better documentation of advantages of Flogger compared to JDK and other logging APIs #78
Comments
There's documentation of this here: https://google.github.io/flogger/benefits |
If that information is hard to find, then we still have a bug here. However, it appears to me that the main flogger page links to that page 5 times in its first two short sections. I usually am reluctant to conclude "we're already doing enough", but that does seem to be the case. |
Reopening to argue that we could do more here -- which is not to say that it needs to be a priority. First, to reemphasize the last part of this sentence: I don't see any need to justify Flogger's existence: It solves problems that Google has, and by open sourcing it, we've made it available to both Google-run open-source projects and other potential users. That's a huge accomplishment for the past 8+ years. So my framing, again, is that, if we do want to make the case to casual users for wider use, then we could take some actions to better highlight what Flogger has to offer. For example:
|
Apologies for a tangential nit, please feel free to ignore this, but I am struggling to wrap my head around how the fluent api avoids for varargs (from the "benefits" doc):
since even against a no-op call site, you are still creating the Object[] for the invocation? Or am I missing something fundamental here? |
It's addressed in more detail in the docs: https://google.github.io/flogger/anatomy.html#avoiding-varargs But TLDR: The API really does enumerate a giant pile of signatures so you're almost certainly calling one of those instead of needing to fallback to varargs With the fluent api, you're able to have "only" those eleventy billion |
A teammate just shared https://tersesystems.com/blog/2022/01/02/echopraxia-a-better-java-logging-api/. For purposes of this thread, there may be some things to mine out of that post and its links. The one that caught my eye was https://github.com/obsidiandynamics/zerolog#okay-arent-there-enough-fa%C3%A7ades-already |
I just want to know details of its advantage, where to get the information?
The text was updated successfully, but these errors were encountered: