-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Madhuban #7237
Comments
Hi @jaikishanpatel! Thank you for your submission :) I quickly reviewed the font, there are a lot of issues regarding the variable export, but we can fix them on our side, if the project is accepted. I put here the fontbakery report: FontBakery reportfontbakery version: 0.10.9 [1] Experimental checks⚠ WARN: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
[code: warning-language-shaping] [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[39] MadhubanVF.ttf🔥 FAIL: Checking file is named canonically. (com.google.fonts/check/canonical_filename)
🔥 FAIL: Checking OS/2 fsType does not impose restrictions. (com.google.fonts/check/fstype)
No such DRM restrictions can be enabled on the Google Fonts collection, so the fsType field must be set to zero (Installable Embedding) instead. [code: drm] 🔥 FAIL: Substitute copyright, registered and trademark symbols in name table entries. (com.google.fonts/check/name/unwanted_chars)
🔥 FAIL: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
🔥 FAIL: Are there non-ASCII characters in ASCII-only NAME table entries? (com.google.fonts/check/name/ascii_only_entries)
🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)
🔥 FAIL: Check glyphs do not have components which are themselves components. (com.google.fonts/check/glyf_nested_components)
Use -F or --full-lists to disable shortening of long lists. [code: found-nested-components] 🔥 FAIL: Check that variable fonts have an HVAR table. (com.google.fonts/check/varfont/has_HVAR)
🔥 FAIL: Font enables smart dropout control in "prep" table instructions? (com.google.fonts/check/smart_dropout)
🔥 FAIL: Check a font's STAT table contains compulsory Axis Values. (com.google.fonts/check/STAT)
🔥 FAIL: Name table entries should not contain line-breaks. (com.google.fonts/check/name/line_breaks)
🔥 FAIL: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)
🔥 FAIL: Validate STAT particle names and values match the fallback names in GFAxisRegistry. (com.google.fonts/check/STAT/gf_axisregistry)
🔥 FAIL: Name table records must not have trailing spaces. (com.google.fonts/check/name/trailing_spaces)
🔥 FAIL: Checking OS/2 Metrics match hhea Metrics. (com.google.fonts/check/os2_metrics_match_hhea)
🔥 FAIL: Check that legacy accents aren't used in composite glyphs. (derived from com.google.fonts/check/legacy_accents) (com.google.fonts/check/legacy_accents)
🔥 FAIL: Glyph names are all valid? (com.google.fonts/check/valid_glyphnames)
A glyph name must be entirely comprised of characters from the following set: A-Z a-z 0-9 .(period) (underscore). A glyph name must not start with a digit or period. There are a few exceptions such as the special glyph ".notdef". The glyph names "twocents", "a1", and "" are all valid, while "2cents" and ".twocents" are not. [code: found-invalid-names] 🔥 FAIL: Font contains unique glyph names? (com.google.fonts/check/unique_glyphnames)
🔥 FAIL: Ensure component transforms do not perform scaling or rotation. (com.google.fonts/check/transformed_components)
🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
Use -F or --full-lists to disable shortening of long lists. [code: unattached-dotted-circle-marks] ⚠ WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
⚠ WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
⚠ WARN: Ensure variable fonts include an avar table. (com.google.fonts/check/mandatory_avar_table)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Checking with ots-sanitize. (com.google.fonts/check/ots)
WARNING: Layout: tags aren't arranged alphabetically. ⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
⚠ WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
Width = 626: Width = 666: ⚠ WARN: Checking Vertical Metric Linegaps. (com.google.fonts/check/linegaps)
⚠ WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̉ į̊ į̋ į̏ į̑ į̒ į̛̀ į̛́ į̛̂ į̛̃ į̛̄ į̛̆ į̛̇ į̛̈ į̛̉ į̛̊ į̛̋ Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Navajo (Latn, 166,319 speakers), Lithuanian (Latn, 2,357,094 speakers). Your font does not cover the following languages that require the soft-dotted feature: Lugbara (Latn, 2,200,000 speakers), Nateni (Latn, 100,000 speakers), Avokaya (Latn, 100,000 speakers), Koonzime (Latn, 40,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Ma’di (Latn, 584,000 speakers), Kom (Latn, 360,685 speakers), Dan (Latn, 1,099,244 speakers), Ejagham (Latn, 120,000 speakers), Igbo (Latn, 27,823,640 speakers), Aghem (Latn, 38,843 speakers), Basaa (Latn, 332,940 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ebira (Latn, 2,200,000 speakers). [code: soft-dotted] ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
Thanks @jaikishanpatel this looks like a great project! I'm assigning to @yanone to take a look (as he has experience with complex script shaping) in Q2 :) |
Thanks @davelab6 . looking forward |
Font Project Git Repo URL:
https://github.com/magictype/Madhuban
Super short description of the Font Family:
'Madhuban' is a clean, geometric humanist sans serif. Scripts: Devanagari & Latin | Classification: Mono-linear Sans serif. Read more about it at MagicType
Requirements:
Google Fonts will publish only fonts that match its requirements. Please familiarize yourself with the complete documentation in the Google Fonts Guide (GF-Guide) and ensure your font project complies with them before submitting the font family. You can also use the Google Fonts Project Template, which will help you create a repository that follows the needed structure and includes build requirements.
Image:
The text was updated successfully, but these errors were encountered: