-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Xuong Typeface #7610
Comments
Hello @TruongNguyenHuy! thank you for your submission! I'm Emma and I work with the Google Fonts team. I took a look to your project, you will find the fontbakery report below (this tool report some fails and warns, according to our specs. If the font is accepted, I'll help you to solve them). However, I see that some glyphs are missing: I can generate the comb accent if you prefer, but I would need a design for the Germandbls (the uppercase one). I put this project in our "submissions to review" milestone, and we will take a look asap! FontBakery reportfontbakery version: 0.12.5 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [1] Xuong.ttfAll other checks[33] Xuong.ttf🔥 FAIL Ensure the font supports case swapping for all its glyphs.
🔥 FAIL Checking OS/2 usWinAscent & usWinDescent.
🔥 FAIL Checking Vertical Metric Linegaps.
Overridden: This check was originally a WARN but was overridden by the ufo profile: For Google Fonts, all messages from this check are considered FAILs. [code: hhea]🔥 FAIL Font contains '.notdef' as its first glyph?
🔥 FAIL Font contains glyphs for whitespace characters?
🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL Checking file is named canonically.
🔥 FAIL Check font names are correct
🔥 FAIL Checking OS/2 fsType does not impose restrictions.
No such DRM restrictions can be enabled on the Google Fonts collection, so the fsType field must be set to zero (Installable Embedding) instead. [code: drm]🔥 FAIL Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
🔥 FAIL Check Google Fonts glyph coverage.
Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]🔥 FAIL Font enables smart dropout control in "prep" table instructions?
🔥 FAIL Check font follows the Google Fonts vertical metric schema
|
Xuong.ttf | |
---|---|
Dehinted Size | 53.8kb |
Hinted Size | 54.3kb |
Increase | 492 bytes |
Change | 0.9 % |
ℹ️ INFO Font has old ttfautohint applied?
- ℹ️ INFO
Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.000', 'Version 1.000']
[code: version-not-detected]
[1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 13 | 16 | 134 | 6 | 81 | 0 |
0% | 0% | 5% | 6% | 54% | 2% | 32% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Hello @emmamarichal I saw your message, and I edited and added the glyphs you requested. I hope you review my font, and give me a reply as soon as possible. Besides, I also hope you can help me solve the errors, because I'm not familiar with those issues. Thank you for everything, have a nice day. |
Yes I'll help for sure! no problem :) |
@emmamarichal please could you take another review pass on this so we can decide how to move forwards :) |
Font Project Git Repo URL:
https://github.com/TruongNguyenHuy/Xuong
Super short description of the Font Family:
An open source display typeface inspired by vehicles traveling on small rivers in Vietnam
Requirements:
I understand that Google Fonts will publish only fonts that matches its requirements, and I can confirm the project meets them (by ticking the cases, or putting x between the square brackets in text mode):
Image:
The text was updated successfully, but these errors were encountered: