Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playpen Sans: Version 1.001 added #6746

Merged
merged 6 commits into from
Sep 25, 2023
Merged

Conversation

vv-monsalve
Copy link
Collaborator

b34dbb7: [gftools-packager] Playpen Sans: Version 1.001 added

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions
Copy link

FontBakery report

fontbakery version: 0.9.1

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[16] PlaypenSans[wght].ttf
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: tifinagh, canadian-aboriginal, yi

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, math, cherokee, coptic

  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh

  • U+0307 COMBINING DOT ABOVE: try adding one of: canadian-aboriginal, tifinagh, math, tai-le, old-permic, malayalam, syriac, coptic

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee

  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
    18 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, symbols, vietnamese [code: unreachable-subsetting]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)
  • WARN We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.51x (1510) [code: bad-hhea-range]
WARN: Check if category on METADATA.pb matches what can be inferred from the family name. (com.google.fonts/check/metadata/category_hints)
  • WARN Familyname seems to hint at "SANS_SERIF" but METADATA.pb declares it as "['HANDWRITING']". [code: inferred-category]
WARN: Check if uppercase glyphs are vertically centered. (com.google.fonts/check/caps_vertically_centered)
  • WARN Uppercase glyphs are not vertically centered in the em box. [code: vertical-metrics-not-centered]
WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
  • WARN This font has a 'Soft Hyphen' character. [code: softhyphen]
WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters should disappear in other cases, for example: į̛̀ į̛́ į̛̂ į̛̃ į̛̄ į̛̆ į̛̇ į̛̈ į̛̉ į̛̊ į̛̋ į̛̌ į̛̒ į̣̀ į̣́ į̣̂ į̣̃ į̣̄ į̣̆ į̣̇

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Navajo (Latn, 166,319 speakers), Igbo (Latn, 27,823,640 speakers), Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Belarusian (Cyrl, 10,064,517 speakers), Aghem (Latn, 38,843 speakers), Basaa (Latn, 332,940 speakers), Ukrainian (Cyrl, 29,273,587 speakers). [code: soft-dotted]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/playpensans/PlaypenSans[wght].ttf
Dehinted Size 508.2kb
Hinted Size 508.3kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.001'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.001"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • INFO Latn [code: dlng-tag]
  • INFO Latn [code: slng-tag]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/playpensans [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 7 46 10 187 0
0% 0% 3% 18% 4% 75% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve
Copy link
Collaborator Author

vv-monsalve commented Sep 22, 2023

⚠ WARN: Check for codepoints not covered by METADATA subsets.

The warning is not reporting about the 'symbols' codepoints and subset yet.
@simoncozens

@vv-monsalve
Copy link
Collaborator Author

This PR updates #6673 with the symbols subset fixes and is related to issue #6377

@vv-monsalve vv-monsalve added I Small Fix bugs fixed but nothing added and removed I Small Fix bugs fixed but nothing added labels Sep 23, 2023
Copy link
Collaborator

@chrissimpkins chrissimpkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does TypeTogether have a minisite URL?

@simoncozens
Copy link
Collaborator

The warning is not reporting about the 'symbols' codepoints and subset yet.

Felipe just released fontbakery 0.9.2 which should contain the fix. I'll hit the CI again.

@github-actions

This comment was marked as outdated.

@vv-monsalve
Copy link
Collaborator Author

vv-monsalve commented Sep 25, 2023

Does TypeTogether have a minisite URL?

Not AFAIK, I'll confirm with them.

Felipe just released fontbakery 0.9.2 which should contain the fix. I'll hit the CI again.

Thanks. Now, the check still suggests including some codepoints in the subset, and I had checked to see the required ones in Lib/glyphsets/encodings. But we can't see the full list, so I am uncertain about which of them are reported as missing.

EDIT: I've updated FB locally and used the -F option. The following is the full list of the reported glyphs.
However, almost all of the symbols codepoints reported as missing in the subset were already included in the PR #127. Only one (0x1F4D6) is actually missing. I've created a new PR for it.

WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)

This check ensures that all encoded glyphs in the font are covered by a subset declared in the METADATA.pb. Google Fonts splits the font into a set of subset fonts based on the contents of the subsets field and the subset definitions in the glyphsets repository.

Any encoded glyphs which are not by any of these subset definitions will not be served in the subsetted fonts, and so will be unreachable to the end user.

  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: canadian-aboriginal, tifinagh, yi

  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, tifinagh, coptic, math

  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh

  • U+0307 COMBINING DOT ABOVE: try adding one of: old-permic, canadian-aboriginal, syriac, tifinagh, malayalam, coptic, tai-le, math

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage

  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le

  • U+0312 COMBINING TURNED COMMA ABOVE: not included in any glyphset definition

  • U+031B COMBINING HORN: not included in any glyphset definition

  • U+0326 COMBINING COMMA BELOW: not included in any glyphset definition

  • U+0327 COMBINING CEDILLA: not included in any glyphset definition

  • U+0328 COMBINING OGONEK: not included in any glyphset definition

  • U+0335 COMBINING SHORT STROKE OVERLAY: not included in any glyphset definition

  • U+0336 COMBINING LONG STROKE OVERLAY: not included in any glyphset definition

  • U+0337 COMBINING SHORT SOLIDUS OVERLAY: not included in any glyphset definition

  • U+0338 COMBINING LONG SOLIDUS OVERLAY: not included in any glyphset definition

  • U+0394 GREEK CAPITAL LETTER DELTA: try adding one of: elbasan, greek, math

  • U+03A9 GREEK CAPITAL LETTER OMEGA: try adding one of: elbasan, greek, math

  • U+03BC GREEK SMALL LETTER MU: try adding one of: greek, math

  • U+03C0 GREEK SMALL LETTER PI: try adding one of: greek, yi, math

  • U+2021 DOUBLE DAGGER: try adding adlam

  • U+2030 PER MILLE SIGN: try adding adlam

  • U+2116 NUMERO SIGN: try adding cyrillic

  • U+2126 OHM SIGN: not included in any glyphset definition

  • U+2202 PARTIAL DIFFERENTIAL: try adding math

  • U+2206 INCREMENT: try adding math

  • U+220F N-ARY PRODUCT: try adding math

  • U+2211 N-ARY SUMMATION: try adding math

  • U+2219 BULLET OPERATOR: try adding one of: tai-tham, symbols, yi, math

  • U+221A SQUARE ROOT: try adding math

  • U+221E INFINITY: try adding math

  • U+222B INTEGRAL: try adding math

  • U+2248 ALMOST EQUAL TO: try adding math

  • U+2260 NOT EQUAL TO: try adding math

  • U+2264 LESS-THAN OR EQUAL TO: try adding math

  • U+2265 GREATER-THAN OR EQUAL TO: try adding math

  • U+25CA LOZENGE: try adding one of: symbols, math

  • U+25CC DOTTED CIRCLE: try adding one of: grantha, wancho, tamil, balinese, yi, bhaiksuki, old-permic, bassa-vah, symbols, sundanese, khudawadi, bengali, syloti-nagri, mandaic, meetei-mayek, music, pahawh-hmong, manichaean, mende-kikakui, tibetan, sogdian, malayalam, lao, osage, hanifi-rohingya, oriya, kharoshthi, kaithi, lepcha, modi, phags-pa, nko, math, marchen, gurmukhi, kayah-li, mongolian, khmer, myanmar, sharada, thaana, tai-viet, tagalog, telugu, brahmi, new-tai-lue, chakma, gunjala-gondi, adlam, psalter-pahlavi, buginese, ahom, siddham, sinhala, elbasan, tifinagh, coptic, tai-le, tagbanwa, caucasian-albanian, masaram-gondi, mahajani, hanunoo, kannada, batak, tirhuta, dogra, gujarati, javanese, miao, soyombo, newa, buhid, zanabazar-square, syriac, limbu, rejang, takri, devanagari, thai, duployan, hebrew, khojki, cham

  • U+270F PENCIL: try adding symbols

  • U+2713 CHECK MARK: try adding symbols

  • U+274C CROSS MARK: not included in any glyphset definition

  • U+FB01 LATIN SMALL LIGATURE FI: not included in any glyphset definition

  • U+FB02 LATIN SMALL LIGATURE FL: not included in any glyphset definition

  • U+1F31E SUN WITH FACE: not included in any glyphset definition

  • U+1F320 SHOOTING STAR: not included in any glyphset definition

  • U+1F382 BIRTHDAY CAKE: not included in any glyphset definition

  • U+1F3A8 ARTIST PALETTE: not included in any glyphset definition

  • U+1F3AF DIRECT HIT: not included in any glyphset definition

  • U+1F3C5 SPORTS MEDAL: not included in any glyphset definition

  • U+1F446 WHITE UP POINTING BACKHAND INDEX: try adding symbols

  • U+1F44D THUMBS UP SIGN: try adding symbols

  • U+1F44E THUMBS DOWN SIGN: try adding symbols

  • U+1F4D6 OPEN BOOK: not included in any glyphset definition

  • U+1F4E3 CHEERING MEGAPHONE: not included in any glyphset definition

  • U+1F50B BATTERY: not included in any glyphset definition

  • U+1F984 UNICORN FACE: not included in any glyphset definition

  • U+1F996 T-REX: not included in any glyphset definition

  • U+1F9E9 JIGSAW PUZZLE PIECE: not included in any glyphset definition

  • U+1FA90 RINGED PLANET: try adding symbols

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, vietnamese [code: unreachable-subsetting]

@vv-monsalve
Copy link
Collaborator Author

vv-monsalve commented Sep 25, 2023

Not AFAIK, I'll confirm with them.

Confirming: They don't have a minisite URL and are not planning one either.
The last codepoint has already been included in the Symbols subset.

@chrissimpkins Can we merge the PR now?

@github-actions
Copy link

FontBakery report

fontbakery version: 0.9.2

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[15] PlaypenSans[wght].ttf
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, tifinagh, canadian-aboriginal

  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage

  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
    16 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, math, menu, symbols, vietnamese [code: unreachable-subsetting]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)
  • WARN We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.51x (1510) [code: bad-hhea-range]
WARN: Check if category on METADATA.pb matches what can be inferred from the family name. (com.google.fonts/check/metadata/category_hints)
  • WARN Familyname seems to hint at "SANS_SERIF" but METADATA.pb declares it as "['HANDWRITING']". [code: inferred-category]
WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
  • WARN This font has a 'Soft Hyphen' character. [code: softhyphen]
WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters should disappear in other cases, for example: į̛̀ į̛́ į̛̂ į̛̃ į̛̄ į̛̆ į̛̇ į̛̈ į̛̉ į̛̊ į̛̋ į̛̌ į̛̒ į̣̀ į̣́ į̣̂ į̣̃ į̣̄ į̣̆ į̣̇

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Navajo (Latn, 166,319 speakers), Igbo (Latn, 27,823,640 speakers), Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Belarusian (Cyrl, 10,064,517 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Basaa (Latn, 332,940 speakers), Aghem (Latn, 38,843 speakers). [code: soft-dotted]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/playpensans/PlaypenSans[wght].ttf
Dehinted Size 508.2kb
Hinted Size 508.3kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.001'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.001"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • INFO Latn [code: dlng-tag]
  • INFO Latn [code: slng-tag]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/playpensans [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 6 46 10 187 0
0% 0% 2% 18% 4% 75% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve
Copy link
Collaborator Author

Per conversation with Chris, I am adding the math to the subsets to receive these glyphs, to prioritize keeping the glyph repertoire for the font.

@vv-monsalve vv-monsalve merged commit 11d5542 into main Sep 25, 2023
9 checks passed
@vv-monsalve vv-monsalve deleted the gftools_packager_ofl_playpensans branch September 25, 2023 19:21
@chrissimpkins
Copy link
Collaborator

Chatted with Viv about this issue today. We added the math subset to include additional code points that were being stripped by the subsetter and are ready to push to sandbox again for testing.

@vv-monsalve
Copy link
Collaborator Author

vv-monsalve commented Sep 26, 2023

Checking the font that has been updated and is now in dev server, the following is observed:

  • The added icons (to the Symbols subset) are not shown, while the ones that are part of the math subset are.
    Screen Shot 2023-09-25 at 20 52 10
  • However, the glyphs are present in the font (testing it in Wakamai)
    Screen Shot 2023-09-25 at 20 57 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

None yet

3 participants