Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the DRC rules have unit tests as well as bigger integration tests #15

Open
mithro opened this issue Aug 3, 2022 · 3 comments

Comments

@mithro
Copy link
Contributor

mithro commented Aug 3, 2022

It is general best practice to have lots of small units which only test one thing at a time. At the moment, the testing in #11 are more like integration tests.

The testing for the DRC rules should look like this -- for each DRC rule, there should be a directory which contains;

  • A human readable description of the rule
  • A set of GDS files which demonstrate different violations which should be caught by the DRC rule. These should also be rendered as examples into the human readable description of the rule.
  • A set of GDS files which should not have any violations in them.
  • These GDS test cases should be run with only the individual DRC rule being enabled.

There should still be DRC integration tests, but they should only be run after all the individual unit tests are successful.

@atorkmabrains
Copy link
Collaborator

@mithro The DRC tests are unit tests for each rule. Unfortunately, it's hard to isolate each rule as the DRc runs takes long time. All tests are integrated one GDS files and we could tell which rule had missed errors or false positive violations. There some parts of the regression system that are not integrated yet. @mohanad0mohamed will integrate them soon that detects each rule on its own. But it will be single run for most of the rules.

@mithro
Copy link
Contributor Author

mithro commented Aug 10, 2022

We should split the GDS file apart so that each test has multiple small GDS files demonstrating one thing at a time.

@atorkmabrains
Copy link
Collaborator

@mithro As we have discussed, we will split the GDS testing file to smaller test units per rule to be able to parallelize the run.

atorkmabrains added a commit to christoph-weiser/globalfoundries-pdk-libs-gf180mcu_fd_pr that referenced this issue Dec 18, 2022
Updating primitives names for 'npn' bjt devices in lvs gds files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants