ci: combine workflows and homogenize testing target names; limit concurrency #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohanad0mohamed
approved these changes
Aug 7, 2022
There was a problem hiding this comment.
@umarcor Great job!
- The
makefilenow looks cleaner. - The
Tests.ymlis doing the same jobs as the separate files was. - I'm not sure if removing comments was a good choice. it would be easier for other developers to understand what is written if they were there.
|
@mohanad0mohamed Could we create a new PR to split the main DRC to smaller parts as well? |
|
@atorkmabrains There is already an issue about that request: #15 |
atorkmabrains
approved these changes
Aug 10, 2022
umarcor
force-pushed
the
umarcor/ci
branch
2 times, most recently
from
4de79db
to
88b10ff
Compare
There was a problem hiding this comment.
@umarcor You moved the klayout version to klayout 0.27.10 we want to use klayout 0.27.8.
|
@atorkmabrains I removed the commit bumping klayout. |
Signed-off-by: Unai Martinez-Corral <umartinezcorral@antmicro.com>
mithro
approved these changes
Aug 11, 2022
|
|
||
| name: Regression testing | ||
|
|
||
| # https://docs.github.com/en/actions/using-jobs/using-concurrency |
There was a problem hiding this comment.
Rather than linking to the concurrency documentation, can you explain why we want / need the concurrency statement?
Signed-off-by: Unai Martinez-Corral <umartinezcorral@antmicro.com>
Signed-off-by: Unai Martinez-Corral <umartinezcorral@antmicro.com>
mithro
approved these changes
Aug 12, 2022
atorkmabrains
added a commit
to christoph-weiser/globalfoundries-pdk-libs-gf180mcu_fd_pr
that referenced
this pull request
Dec 18, 2022
Updating primitives names in cdl files used for LVS testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13
/cc @mithro