Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding GitHub Actions for DRC testing #11

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Adding GitHub Actions for DRC testing #11

merged 1 commit into from
Aug 3, 2022

Conversation

mohanad0mohamed
Copy link
Contributor

@mohanad0mohamed mohanad0mohamed commented Aug 2, 2022 •
edited
Loading

Fixes #3

All actions required for DRC are now running, but needs this PR #10 to be merged first.

  • SC DRC
  • DRC regression
  • DRC switch checking
  • SRAM DRC
  • IO DRC

mithro
mithro suggested changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question about sram in sc_testcases directory?

@mithro
Copy link
Contributor

mithro commented Aug 2, 2022

@umarcor - I would appreciate your thoughts on this pull request.

@atorkmabrains
Copy link
Collaborator

@mohanad0mohamed Could you please change the target name to match what @mithro has requested? I agree that it would make the target more readable and understandable.

@atorkmabrains
Copy link
Collaborator

@mithro This is not a complete DRC regression. But merging this version is very important. There are 2 updates that will be done that will make the regression more robust and able to detect changes that might affect the DRC quality.

@mohanad0mohamed
Copy link
Contributor Author

@mithro @atorkmabrains All requested changes had been made.

https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/compare/c33cc53b56b95569e406d7bcc03d538a4b4c43a6..0fbc1c39faf03e5b3fc1e642ebe5eb4e369f08b9

atorkmabrains
atorkmabrains approved these changes Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@atorkmabrains atorkmabrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the changes made in this PR.

This was referenced Aug 3, 2022
Closed
Closed
Open
mithro
mithro approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this pull request, but I logged #15, #14 and #13 which should be fixed in follow on pull requests.

@mithro mithro merged commit 114a3ab into google:main Aug 3, 2022
@mithro mithro deleted the drc_actions branch August 3, 2022 15:42
atorkmabrains added a commit to christoph-weiser/globalfoundries-pdk-libs-gf180mcu_fd_pr that referenced this pull request Dec 18, 2022
@atorkmabrains
Merge pull request google#11 from mabrains/primitives_names_part3
1b7ace2 
 Updating primitves names in lvs rule deck and its README file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mithro mithro mithro approved these changes

@atorkmabrains atorkmabrains atorkmabrains approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The KLayout DRC rule tests should be run using GitHub Actions
3 participants
@mohanad0mohamed @mithro @atorkmabrains