Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding GitHub Actions for LVS testing #12

Merged
merged 1 commit into from Aug 3, 2022
Merged

Adding GitHub Actions for LVS testing #12

merged 1 commit into from Aug 3, 2022

Conversation

mohanad0mohamed
Copy link
Contributor

Fixes #4

All actions required for LVS are now running.

  • LVS extraction checking
  • SC LVS
  • LVS regression

mithro
mithro suggested changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are sram test cases being added under the sc_testscases directory which I assume stands for "standard cell"?

.github/workflows/lvs_gf180mcu_fd_sc_test.yml Outdated Show resolved Hide resolved
@mithro
Copy link
Contributor

mithro commented Aug 2, 2022

@umarcor - I would appreciate your thoughts on this pull request.

@atorkmabrains
Copy link
Collaborator

@mohanad0mohamed Please split the run to smaller runs allowing the github actions to be parallelized and controlled easier.

@mithro You are right it stand for SC. But testing the RAM as well would be helpful. It's basically part of the digital library.

@mohanad0mohamed
Copy link
Contributor Author

@mithro @atorkmabrains All requested changes had been made.

Note: the SRAM cells aren't included because they are still under development for LVS matching.

https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/compare/be2e2bf399e75eec66158e36306de3cb040a6c05..67c9e7c62c477528398ab953f9ba101f6d9201ed

This was referenced Aug 3, 2022
Closed
Closed
mithro
mithro approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this pull request, but follow on work should be done to address #13

@mithro mithro merged commit 2e2eb4a into google:main Aug 3, 2022
@atorkmabrains atorkmabrains deleted the lvs_actions branch August 9, 2022 09:12
atorkmabrains added a commit to christoph-weiser/globalfoundries-pdk-libs-gf180mcu_fd_pr that referenced this pull request Dec 18, 2022
@atorkmabrains
Merge pull request google#12 from mabrains/primitives_names_part4
93e3836 
Updating primitives names in [ip , manual, extraction checking] testc…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mithro mithro mithro approved these changes

@atorkmabrains atorkmabrains Awaiting requested review from atorkmabrains

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The KLayout LVS tests should be run using GitHub Actions
3 participants
@mohanad0mohamed @mithro @atorkmabrains