Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the GitHub Actions to reduce significant duplication in workflow files #13

Closed
mithro opened this issue Aug 3, 2022 · 4 comments · Fixed by #18
Closed

Improve the GitHub Actions to reduce significant duplication in workflow files #13

mithro opened this issue Aug 3, 2022 · 4 comments · Fixed by #18

Comments

@mithro
Copy link
Contributor

mithro commented Aug 3, 2022

Pull requests #12 and #11 added a whole bunch of GitHub Actions for checking various things.

The workflow files currently have large amount of duplicate in them. Instead we should be using "matrix" for this stuff. See the documentation at #11

@mithro
Copy link
Contributor Author

mithro commented Aug 3, 2022

@umarcor - Can you help the @mabrains team understand how to do this?

@mohanad0mohamed
Copy link
Contributor

@mithro I think this may not work. From GitHub themselves in https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs are saying you can use a matrix strategy to test your code in multiple versions of a language or on multiple operating systems.
Also, running multiple DRC/LVS checks in the same job in parallel may crash due to the capability of GitHub Actions hosted runners in https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners:

Hardware specification for Windows and Linux virtual machines:

    2-core CPU (x86_64)
    7 GB of RAM
    14 GB of SSD space

So I assume "matrix" won't fix this issue.

@umarcor
Copy link
Collaborator

umarcor commented Aug 5, 2022

@mohanad0mohamed the matrix does not run multiple tasks on the same job, it generates multiple jobs in parallel. See #18.

@mohanad0mohamed
Copy link
Contributor

@umarcor I'm amazed how "matrix" removed all duplicated jobs!
Now I understand how it works. Many thanks.

atorkmabrains added a commit to christoph-weiser/globalfoundries-pdk-libs-gf180mcu_fd_pr that referenced this issue Dec 18, 2022
Updating primitives names in cells directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
3 participants