New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oc_config_validate retries gNMI Set messages, it should only retry Gets #310

Closed

JoseIgnacioTamayo opened this issue Nov 10, 2022 · 0 comments

Contributor

JoseIgnacioTamayo commented Nov 10, 2022

oc_config_validate can retry gNMI messages when assertions fail. This is to account for different delays in reflecting back configuration or state.

However, currently it is also retrying gNMI Set messages. This is not correct, as a Target needs only 1 successful SET message to do its job.

The retry mechanism must only apply to gNMI Get messages.

JoseIgnacioTamayo mentioned this issue

Ensure tests only retry gNMI Gets, not gNMI Sets #311

Merged

JoseIgnacioTamayo closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment