Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob/fileblob: no_temp_dir URL option defined inconsistently in #3296 #3299

Closed
maxfisher-g opened this issue Aug 8, 2023 · 1 comment · Fixed by #3300
Closed

blob/fileblob: no_temp_dir URL option defined inconsistently in #3296 #3299

maxfisher-g opened this issue Aug 8, 2023 · 1 comment · Fixed by #3300

Comments

@maxfisher-g
Copy link

maxfisher-g commented Aug 8, 2023

Describe the bug

The URLOpener options for fileblob define the URL option string for the new NoTempDir option inconsistently, meaning it is impossible to actually set this option using the URL method.

In UrlOpener.forParams() the string is defined as no_temp_dir but the recognizedParams list (and the documentation) defines it as no_tmp_dir.

To Reproduce

Add ?no_temp_dir=true to the bucket URL string passed to blob.OpenBucket. Opening the bucket returns an error message invalid query parameter "no_temp_dir"

Add ?no_tmp_dir=true to the bucket URL string passed to blob.OpenBucket. The option has no effect.

Expected behavior

The NoTempDir option is set for the bucket with no error message.

Version

master

Additional context

Introduced in #3296 / a048d52, relevant to #3294

@vangent
Copy link
Contributor

vangent commented Aug 8, 2023

Oops! Thanks for the report, PR on the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants