Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop xerrors since functionality is merged to errors in std lib #225

Closed
wants to merge 1 commit into from
Closed

Drop xerrors since functionality is merged to errors in std lib #225

wants to merge 1 commit into from

Conversation

arvenil
Copy link

@arvenil arvenil commented Jun 26, 2020

Drop the only dependency since all functionality from xerrors used in go-cmp is now merged to errors in standarad library.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@arvenil
Copy link
Author

arvenil commented Jun 26, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@dsnet
Copy link
Collaborator

dsnet commented Jun 26, 2020

Thanks for the PR, but we can't accept this. The new errors API was added in go1.14, but our current minimally supported version is go1.8. The cmp package is very widely used, so we need to support a wide range of Go versions. It will be a long time before we get to go1.14 is the minimally supported version.

@arvenil
Copy link
Author

arvenil commented Jun 26, 2020

Hi, makes sense, feel free to close it. However I'm suprised since people using older golang version can always download older go-cmp version 🤷.

@dsnet
Copy link
Collaborator

dsnet commented Jun 26, 2020

people using older golang version can always download older go-cmp version 🤷.

It's not quite that simple. Suppose there is module A at version v1.5 and that module depends on cmp at version v0.6 (with go1.14 as the minimum support).

If you're constrained to an old version of Go and want to use A@v1.5, you're stuck since it requires you to use cmp@v0.6, which requires that you use go1.14.

Closing this PR since we won't get to this point for at least a year or more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants