Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xerrors dependency and use stdlib. #243

Closed
wants to merge 2 commits into from
Closed

Remove xerrors dependency and use stdlib. #243

wants to merge 2 commits into from

Conversation

googollee
Copy link

No description provided.

@google-cla
Copy link

google-cla bot commented Nov 13, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@dsnet
Copy link
Collaborator

dsnet commented Nov 13, 2020

I apologize, but we can't accept this change. See #225 (comment)

@dsnet dsnet closed this Nov 13, 2020
@googollee
Copy link
Author

I understand that it needs to support Go 1.8. As go mod has version control, could we raise the version number to drop the dependency? If users want to use it under Go 1.14, they could pin the version 0.5.x.

@dsnet
Copy link
Collaborator

dsnet commented Nov 13, 2020

See #225 (comment)

@googollee
Copy link
Author

Thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants