Add diffing abilities to reporting #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitshur
reviewed
Jul 17, 2017
cmp/example_test.go
Outdated
| @@ -147,6 +147,7 @@ func ExampleOption_equalEmpty() { | |||
| // false | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Is this change intentional?
It looks like it makes the file no longer gofmted.
There was a problem hiding this comment.
Would you like a PR that adds a gofmt check to Travis CI, so this type of issue can be caught automatically by CI in all future contributions?
There was a problem hiding this comment.
That would be great, thank you.
dsnet
pushed a commit
that referenced
this pull request
Jul 17, 2017
The default test script is `go test -v ./...` according to Travis docs at https://docs.travis-ci.com/user/languages/go/#Default-Test-Script. Add an additional gofmt check to help catch formatting issues in PRs. This is motivated by a previous occurrence at #9 (comment). Also swap the order of Go versions 1.x and 1.6. 1.x is higher priority, so it makes more sense to run it first and report issues right away. 1.6 is lower priority, so it's better to prioritize it lower. Use 2 space indent in the .yml file, which is consistent with the formatting in Travis documentation and examples.
dsnet
force-pushed
the
diff
branch
2 times, most recently
from
96e2544
to
be2c714
Compare
This adds an internal package with the following API:
func Difference(nx, ny int, f EqualFunc) (eq bool, es EditScript)
type EditScript []EditType
type EditType int8
const Identity EditType = iota ...
type EqualFunc func(ix int, iy int) Result
type Result struct{ ... }
The cmp.SliceIndex type has a new method SplitKeys to indicate that
elements are being compared in x and y are in different indexes.
The debug visualizer can be run:
go test -tags=debug -v github.com/google/go-cmp/cmp/internal/diff
Reviewed-By: kevlar@google.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an internal package with the following API:
func Difference(nx, ny int, f EqualFunc) (eq bool, es EditScript)
type EditScript []EditType
type EditType int8
const Identity EditType = iota ...
type EqualFunc func(ix int, iy int) Result
type Result struct{ ... }
The cmp.SliceIndex type has a new method SplitKeys to indicate that
elements are being compared in x and y are in different indexes.
The debug visualizer can be run:
go test -tags=debug -v github.com/google/go-cmp/cmp/internal/diff
Reviewed-By: dneil@google.com