Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert mistakenly added fields in DraftReviewComment #3219

Closed
matt-simons opened this issue Jul 24, 2024 · 1 comment · Fixed by #3218
Closed

Revert mistakenly added fields in DraftReviewComment #3219

matt-simons opened this issue Jul 24, 2024 · 1 comment · Fixed by #3218

Comments

@matt-simons
Copy link
Contributor

In #3169 I mistakenly added CommitID, InReplyTo, and SubjectType to DraftReviewComment while referring to https://docs.github.com/en/rest/pulls/reviews?apiVersion=2022-11-28#create-a-review-for-a-pull-request. These fields are not however supported in the comments array of https://docs.github.com/en/rest/pulls/reviews?apiVersion=2022-11-28#create-a-review-for-a-pull-request which is what DraftReviewComment was intended for. Sorry for the confusion and time wasted.

My intention was to mimic the workflow in the github UI where you can submit a pull request review with review comments on files instead of a line numbers, however on second look I don't think this is possible to do via the API, please correct me if I'm wrong again.

Revert for PR #3218

@gmlewis
Copy link
Collaborator

gmlewis commented Jul 25, 2024

My intention was to mimic the workflow in the github UI where you can submit a pull request review with review comments on files instead of a line numbers, however on second look I don't think this is possible to do via the API, please correct me if I'm wrong again.

I believe you are correct. The GitHub UI appears to take advantage of many of the GitHub v4 GraphQL API, which this repo doesn't support. See README.md for more information about this other API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants