Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support update to organization and team invitations APIs #514

Closed
gmlewis opened this issue Jan 12, 2017 · 8 comments
Closed

Support update to organization and team invitations APIs #514

gmlewis opened this issue Jan 12, 2017 · 8 comments
Assignees
@varadarajana

Comments

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 12, 2017

Announcement:
https://developer.github.com/changes/2017-01-12-organization-team-invitation-update/
@varadarajana
Copy link
Contributor

Can this be assigned to me?

@gmlewis
Copy link
Collaborator Author

gmlewis commented Jan 16, 2017

I'll send you an invite.

@varadarajana
Copy link
Contributor

Since I already have a PR open, I am planning to create a branch for this feature change, and then create the new PR on it. Is this the right approach?

@dmitshur
Copy link
Member

dmitshur commented Jan 17, 2017 •
edited

Yep, that's the way to go. 👍 When creating the second PR, pick your new branch as the head branch.

@varadarajana
Copy link
Contributor

First i wanted to started writing test cases for the ListPendingTeamInvitations. Here the method mock server returns only "id" which is compared in test case. It was not including values for Login, Email, Role, CreatedAt. Do I need to modify, since i need to now test with "inviter"?

@dmitshur
Copy link
Member

Yes, feel free to expand TestOrganizationsService_ListPendingTeamInvitations test data to be more complete, and include the new inviter field there too.

varadarajana added a commit to varadarajana/go-github that referenced this issue Jan 21, 2017
@varadarajana
google#514: added inviter to Invitation for orgs and teams invite
74b3db5
@varadarajana varadarajana mentioned this issue Jan 21, 2017
Closed
varadarajana added a commit to varadarajana/go-github that referenced this issue Jan 21, 2017
@varadarajana
google#514: go fmt
4a4a270
varadarajana added a commit to varadarajana/go-github that referenced this issue Jan 21, 2017
@varadarajana
google#514: removed prints
3f2f969
varadarajana added a commit to varadarajana/go-github that referenced this issue Jan 21, 2017
@varadarajana
google#514: changed time data types and included them in test
1d7107a
varadarajana added a commit to varadarajana/go-github that referenced this issue Jan 21, 2017
@varadarajana
google#514 Added Org List Pending Invitations
f5b2eeb
varadarajana added a commit to varadarajana/go-github that referenced this issue Jan 21, 2017
@varadarajana
google#514 removed typos in error handling
112d718
@varadarajana
Copy link
Contributor

@shurcooL , @gmlewis i have made the changes and submitted a PR. Can you please review the PR?

@dmitshur
Copy link
Member

Yep, I've done so just now.

varadarajana added a commit to varadarajana/go-github that referenced this issue Jan 28, 2017
@varadarajana
google#514: Modified to pointer time.Time in Invitation
2a95ca6
varadarajana added a commit to varadarajana/go-github that referenced this issue Jan 29, 2017
@varadarajana
google#514: Set up Naming conventions for multi words, pointer to bool
6305685
varadarajana added a commit to varadarajana/go-github that referenced this issue Jan 29, 2017
@varadarajana
google#514: multi word variable format
1840a00
varadarajana added a commit to varadarajana/go-github that referenced this issue Jan 30, 2017
@varadarajana
google#514 : used User instead of new struct
5c4cab8
varadarajana added a commit to varadarajana/go-github that referenced this issue Jan 30, 2017
@varadarajana
google#514 : removed Inviter struct
e732a04
varadarajana added a commit to varadarajana/go-github that referenced this issue Jan 31, 2017
@varadarajana
google#514: Added quotes to list values in comment
1bd4328
@gmlewis gmlewis closed this as completed in 0e7db46 Feb 1, 2017
gmlewis pushed a commit that referenced this issue Mar 8, 2017
@varadarajana @gmlewis
Issue530: Resolves fully Issue 530: new web hooks project, project ca…
2694dca 
…rd and project column (#544)

* #514: added inviter to Invitation for orgs and teams invite

* #514: go fmt

* #514: removed prints

* #514: changed time data types and included them in test

* #514 Added Org List Pending Invitations

* #514 removed typos in error handling

* #514: Modified to pointer time.Time in Invitation

* #514: Set up Naming conventions for multi words, pointer to bool

* #514: multi word variable format

* #514 : used User instead of new struct

* #514 : removed Inviter struct

* #514: Added quotes to list values in comment

* implementation of webhooks for project, projectcard and project column

* Added Changes in event types

* Added Comment for variables populated by webhook

* #530: Made all Changes struct inline

* #530: Modified Changes Structs to include the full names of Changes

* #530 : Review comments from gmlewis fixed

* #530 : Fixed Consistency issues with GitHub docs #562

* #530:generator code
BOTBrad pushed a commit to BOTBrad/go-github that referenced this issue Jun 16, 2017
@varadarajana @gmlewis
Add inviter to Invitation for orgs and teams invite
7c30bb8 
Fixes google#514.
Closes google#527.

Change-Id: Id42e4304aae2388af67dca345bf12aa042b773f1
BOTBrad pushed a commit to BOTBrad/go-github that referenced this issue Jun 16, 2017
@varadarajana @gmlewis
Issue530: Resolves fully Issue 530: new web hooks project, project ca…
6fe3755 
…rd and project column (google#544)

* google#514: added inviter to Invitation for orgs and teams invite

* google#514: go fmt

* google#514: removed prints

* google#514: changed time data types and included them in test

* google#514 Added Org List Pending Invitations

* google#514 removed typos in error handling

* google#514: Modified to pointer time.Time in Invitation

* google#514: Set up Naming conventions for multi words, pointer to bool

* google#514: multi word variable format

* google#514 : used User instead of new struct

* google#514 : removed Inviter struct

* google#514: Added quotes to list values in comment

* implementation of webhooks for project, projectcard and project column

* Added Changes in event types

* Added Comment for variables populated by webhook

* google#530: Made all Changes struct inline

* google#530: Modified Changes Structs to include the full names of Changes

* google#530 : Review comments from gmlewis fixed

* google#530 : Fixed Consistency issues with GitHub docs google#562

* google#530:generator code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varadarajana varadarajana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmitshur @gmlewis @varadarajana