Improve consistency of "GitHub API docs" strings in comments. #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were various slight variations in the phrasing of comments with the form: // GitHub API docs: https://developer.github.com/v3/... This change makes them all consistent. Also fix "GitHub" misspelled as "Github" in a few places. Followup to #551.
varadarajana
added a commit
to varadarajana/go-github
that referenced
this pull request
Mar 4, 2017
gmlewis
pushed a commit
that referenced
this pull request
Mar 8, 2017
…rd and project column (#544) * #514: added inviter to Invitation for orgs and teams invite * #514: go fmt * #514: removed prints * #514: changed time data types and included them in test * #514 Added Org List Pending Invitations * #514 removed typos in error handling * #514: Modified to pointer time.Time in Invitation * #514: Set up Naming conventions for multi words, pointer to bool * #514: multi word variable format * #514 : used User instead of new struct * #514 : removed Inviter struct * #514: Added quotes to list values in comment * implementation of webhooks for project, projectcard and project column * Added Changes in event types * Added Comment for variables populated by webhook * #530: Made all Changes struct inline * #530: Modified Changes Structs to include the full names of Changes * #530 : Review comments from gmlewis fixed * #530 : Fixed Consistency issues with GitHub docs #562 * #530:generator code
bubg-dev
pushed a commit
to bubg-dev/go-github
that referenced
this pull request
Jun 16, 2017
…#562) There were various slight variations in the phrasing of comments with the form: // GitHub API docs: https://developer.github.com/v3/... This change makes them all consistent. Also fix "GitHub" misspelled as "Github" in a few places. Followup to google#551.
bubg-dev
pushed a commit
to bubg-dev/go-github
that referenced
this pull request
Jun 16, 2017
…rd and project column (google#544) * google#514: added inviter to Invitation for orgs and teams invite * google#514: go fmt * google#514: removed prints * google#514: changed time data types and included them in test * google#514 Added Org List Pending Invitations * google#514 removed typos in error handling * google#514: Modified to pointer time.Time in Invitation * google#514: Set up Naming conventions for multi words, pointer to bool * google#514: multi word variable format * google#514 : used User instead of new struct * google#514 : removed Inviter struct * google#514: Added quotes to list values in comment * implementation of webhooks for project, projectcard and project column * Added Changes in event types * Added Comment for variables populated by webhook * google#530: Made all Changes struct inline * google#530: Modified Changes Structs to include the full names of Changes * google#530 : Review comments from gmlewis fixed * google#530 : Fixed Consistency issues with GitHub docs google#562 * google#530:generator code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #551, I noticed that there were various slight variations in the phrasing of comments with the form:
This change makes them all consistent.
Also fix "GitHub" misspelled as "Github" in a few places.
Followup to #551. /cc @kevinburke