Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new Webhooks for Projects #530

Closed
gmlewis opened this issue Jan 26, 2017 · 9 comments
Closed

Support new Webhooks for Projects #530

gmlewis opened this issue Jan 26, 2017 · 9 comments
Assignees
@varadarajana
Labels
enhancement good first issue

Comments

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 26, 2017

Announcement:
https://developer.github.com/changes/2017-01-24-project-webhooks/
@varadarajana
Copy link
Contributor

@gmlewis I would like to work on this issue. Can you please assign this to me?

@gmlewis
Copy link
Collaborator Author

gmlewis commented Jan 29, 2017

Done. Thank you, @varadarajana!

@sahildua2305
Copy link
Member

@varadarajana how's it going with this one?

@dmitshur
Copy link
Member

There's an open PR #530 that mentions it.

@dmitshur dmitshur mentioned this issue Feb 13, 2017
Merged
@sahildua2305
Copy link
Member

@shurcooL oh yes, alright!

@varadarajana it's always good to mention the issue you're trying to resolve in the PR so that others also know that there is/was a PR for this issue and may get to know the history of an issue. 😄

@varadarajana varadarajana mentioned this issue Feb 17, 2017
Closed
@varadarajana
Copy link
Contributor

Sure @sahildua2305, I have changed it now.

varadarajana added a commit to varadarajana/go-github that referenced this issue Feb 22, 2017
@varadarajana
google#530: Made all Changes struct inline
b93fcdf
@varadarajana varadarajana mentioned this issue Mar 2, 2017
Closed
3 tasks
varadarajana added a commit to varadarajana/go-github that referenced this issue Mar 3, 2017
@varadarajana
google#530: Modified Changes Structs to include the full names of Cha…
8ecbfc1 
…nges
varadarajana added a commit to varadarajana/go-github that referenced this issue Mar 4, 2017
@varadarajana
google#530 : Review comments from gmlewis fixed
d2255a9
varadarajana added a commit to varadarajana/go-github that referenced this issue Mar 4, 2017
@varadarajana
google#530 : Fixed Consistency issues with GitHub docs google#562
e9fedb9
varadarajana added a commit to varadarajana/go-github that referenced this issue Mar 7, 2017
@varadarajana
google#530:generator code
25cadb0
gmlewis pushed a commit that referenced this issue Mar 8, 2017
@varadarajana @gmlewis
Issue530: Resolves fully Issue 530: new web hooks project, project ca…
2694dca 
…rd and project column (#544)

* #514: added inviter to Invitation for orgs and teams invite

* #514: go fmt

* #514: removed prints

* #514: changed time data types and included them in test

* #514 Added Org List Pending Invitations

* #514 removed typos in error handling

* #514: Modified to pointer time.Time in Invitation

* #514: Set up Naming conventions for multi words, pointer to bool

* #514: multi word variable format

* #514 : used User instead of new struct

* #514 : removed Inviter struct

* #514: Added quotes to list values in comment

* implementation of webhooks for project, projectcard and project column

* Added Changes in event types

* Added Comment for variables populated by webhook

* #530: Made all Changes struct inline

* #530: Modified Changes Structs to include the full names of Changes

* #530 : Review comments from gmlewis fixed

* #530 : Fixed Consistency issues with GitHub docs #562

* #530:generator code
@dmitshur
Copy link
Member

dmitshur commented Mar 8, 2017 •
edited

This issue was resolved via PR #544, which was recently merged, so closing.

Note, it wasn't closed automatically because neither the PR description, nor the commit message of 2694dca said "Closes #530." or equivalent. I also mentioned this in #544 (comment). /cc @varadarajana @gmlewis FYI.

@dmitshur dmitshur closed this as completed Mar 8, 2017
@gmlewis
Copy link
Collaborator Author

gmlewis commented Mar 8, 2017

Ah, so that is the case where I would need to add to the commit message during "Squash and merge" then. Thanks, @shurcooL.

@dmitshur
Copy link
Member

dmitshur commented Mar 8, 2017 •
edited

Yep, at least one of the PR description or commit message needs to mention that it resolves an issue, otherwise GitHub has no way of knowing what issue(s), if any, to automatically close.

References:

Note that Pull Request title does not count, it has to be in the body, and it has to match the expected syntax exactly:

All you have to do is include the special keyword syntax (eg. fixes #5) in the body of your Pull Request.

BOTBrad pushed a commit to BOTBrad/go-github that referenced this issue Jun 16, 2017
@varadarajana @gmlewis
Issue530: Resolves fully Issue 530: new web hooks project, project ca…
6fe3755 
…rd and project column (google#544)

* google#514: added inviter to Invitation for orgs and teams invite

* google#514: go fmt

* google#514: removed prints

* google#514: changed time data types and included them in test

* google#514 Added Org List Pending Invitations

* google#514 removed typos in error handling

* google#514: Modified to pointer time.Time in Invitation

* google#514: Set up Naming conventions for multi words, pointer to bool

* google#514: multi word variable format

* google#514 : used User instead of new struct

* google#514 : removed Inviter struct

* google#514: Added quotes to list values in comment

* implementation of webhooks for project, projectcard and project column

* Added Changes in event types

* Added Comment for variables populated by webhook

* google#530: Made all Changes struct inline

* google#530: Modified Changes Structs to include the full names of Changes

* google#530 : Review comments from gmlewis fixed

* google#530 : Fixed Consistency issues with GitHub docs google#562

* google#530:generator code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varadarajana varadarajana

Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dmitshur @sahildua2305 @gmlewis @varadarajana