Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

methods return non-nil resources on error #58

Closed
willnorris opened this issue Sep 20, 2013 · 0 comments
Closed

methods return non-nil resources on error #58

willnorris opened this issue Sep 20, 2013 · 0 comments

Comments

@willnorris
Copy link
Collaborator

take for example:

repo, _, err := client.Repositories.Get("foo", "bar")

If foo/bar is not a valid repository, I would expect repo to be nil. Currently, it's set to an empty (but non-nil) Repository. I guess I just didn't really think about this when setting things up initially. This should be fixed throughout the library. It won't require changing any method signatures, just some behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant