Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ruby 2.5 support #648

Merged
merged 2 commits into from Mar 22, 2018
Merged

Add Ruby 2.5 support #648

merged 2 commits into from Mar 22, 2018

Conversation

sponomarev
Copy link
Contributor

Hi there!

Accordingly, to this commit ruby/ruby@0078e40, multiline headers are no more acceptable. It's a pity, but the library generates User-Agent with OS version which contains trailing newline.

This PR solves the issue and add explicit Ruby 2.4 and 2.5 support to test against on CI.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jan 16, 2018
@coveralls
Copy link

coveralls commented Jan 18, 2018 •
edited

Coverage Status

Coverage decreased (-0.09%) to 95.991% when pulling 5389945 on sponomarev:fix/ruby-2.5 into 8504b3d on google:master.

@brchristian
Copy link

@sqrrrl This issue with Ruby 2.5 compatibility which this PR addresses is a showstopper for us and for anyone trying to use the google-api-ruby-client gem with Ruby 2.5 (and higher). Let me know if there is anything we can do to help get this PR merged!

@sponomarev
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 1, 2018
@sponomarev sponomarev mentioned this pull request Mar 1, 2018
Closed
dentarg referenced this pull request in dentarg/skuld Mar 5, 2018
@dentarg
Use Ruby 2.4
a26eb99 
Can't go to 2.5 due to https://bugs.ruby-lang.org/issues/14071 :-(
@hasghari
Copy link

Any resolution to this issue?

@sponomarev
Copy link
Contributor Author

Hey @grant, sorry for bugging you! Any chance that it could be merged? A lot of production projects are suffering...

@grant grant merged commit 3bffde3 into googleapis:master Mar 22, 2018
@sponomarev sponomarev deleted the fix/ruby-2.5 branch March 22, 2018 20:05
hmnhf added a commit to Taskulu/google-api-ruby-client that referenced this pull request Apr 5, 2018
@hmnhf
Fix user agent header field value error
5530340 
* Multi-line headers are no longer acceptable.
* googleapis#648
@DawidJanczak DawidJanczak mentioned this pull request Apr 20, 2018
Closed
@mattwhisenhunt mattwhisenhunt mentioned this pull request Apr 20, 2018
Closed
@dentarg dentarg mentioned this pull request Apr 23, 2018
Open
@DaryMerckensGT DaryMerckensGT mentioned this pull request May 23, 2018
Closed
@dnazila dnazila mentioned this pull request Jun 1, 2018
Closed
@pfeiffer pfeiffer mentioned this pull request Aug 9, 2018
Closed
mattysweeps added a commit to cloudfoundry-community/stackdriver-tools that referenced this pull request Jan 15, 2019
@mattysweeps
Update google-client-apis gem for fluentd
f5b3a7c 
To fix a bug with multiline syslog messages:
googleapis/google-api-ruby-client#648
mattysweeps added a commit to cloudfoundry-community/stackdriver-tools that referenced this pull request Jan 15, 2019
@mattysweeps
Update google-client-apis gem for fluentd
c8bb16f 
To fix a bug with multiline syslog messages:
googleapis/google-api-ruby-client#648
domhnallmurphy-examtime added a commit to ExamTime/google-api-ruby-client that referenced this pull request Jan 18, 2019
@domhnallmurphy-examtime
Attempting to retrofit PR to older library version
fbf94a6 
googleapis#648
winebarrel added a commit to muuseo/google-api-ruby-client that referenced this pull request Feb 25, 2019
@winebarrel
Backport googleapis#648 to v0.8.1.1
aa0ffa8
O-I added a commit to O-I/google-api-ruby-client that referenced this pull request Oct 10, 2019
@O-I
Patch ENV::OS_VERSION
6ed54b9 
To support Ruby 2.5+ on `google-api-client 0.8.6` we need to strip the
newline in `ENV::OS_VERSION`. This is a temporary solution until we can
upgrade to a curent version that has this patch merged.

See this [issue][1] for more.

[1]: googleapis#648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sponomarev @googlebot @coveralls @brchristian @hasghari @grant