Fix latest Rubocop errors #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
@dazuma This change won't work, because rubocop v0.50 has inherently conflict rules for Ruby 1.9 vs Ruby 2.x. In order to upgrade to rubocop v0.50+, this gem has to drop support for Ruby 1.9 first, or include exceptions on the conflicting rules. |
|
Seems like the Travis build just failed, as expected, on Ruby 1.9 build. |
|
Ugh, you're right, rubocop 0.50 is explicitly not compatible with 1.9. Thanks for the info! I guess the next step is to figure out how long we're going to continue to support unsupported Ruby versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style fixes that let us unpin rubocop and update it to 0.50.