New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds more robust checking of the status code during compute engine auth. #25

Merged

sqrrrl merged 3 commits into googleapis:master from tbetbetbe:ruby-auth-check-404-on-compute

Apr 23, 2015

Contributor

tbetbetbe commented Apr 23, 2015

Currently the implementation does not verify that a 200 response is received
before attempting to parse the JSON response.

This PR updates the behaviour to fail with an authorization error, similar to
how other auth library implementations.

Fixes #23


          Adds more robust checking of the status code during compute engine auth.

98816f7

Currently the implementation does not verify that a 200 response is received
before attempting to parse the JSON response.

This PR updates the behaviour to fail with an authorization error, similar to
how other auth library implementations.

tbetbetbe assigned sqrrrl

coveralls commented Apr 23, 2015

Coverage increased (+0.03%) to 99.26% when pulling 98816f7 on tbetbetbe:ruby-auth-check-404-on-compute into 2924980 on google:master.

1 similar comment

coveralls commented Apr 23, 2015

Coverage increased (+0.03%) to 99.26% when pulling 98816f7 on tbetbetbe:ruby-auth-check-404-on-compute into 2924980 on google:master.

sqrrrl reviewed

View reviewed changes

spec/googleauth/compute_engine_spec.rb

+                      stubs.verify_stubbed_calls
+                    end
+                    it 'should fail if metadata the request returns an unexpected codes' do

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Contributor

sqrrrl commented Apr 23, 2015

I take it the end result is still the same -- an error (albeit a more informative one :) will be raised if --no-scope is used?

Contributor Author

tbetbetbe commented Apr 23, 2015

That's correct. That's consistent with how java and python handle it.

Tim Emiola added 2 commits

April 23, 2015 11:19


          Updates conditional logic to use a case clause

194128d


          Corrects grammar

fe1c46c

coveralls commented Apr 23, 2015

Coverage increased (+0.03%) to 99.27% when pulling fe1c46c on tbetbetbe:ruby-auth-check-404-on-compute into 2924980 on google:master.

2 similar comments

coveralls commented Apr 23, 2015

Coverage increased (+0.03%) to 99.27% when pulling fe1c46c on tbetbetbe:ruby-auth-check-404-on-compute into 2924980 on google:master.

coveralls commented Apr 23, 2015

Coverage increased (+0.03%) to 99.27% when pulling fe1c46c on tbetbetbe:ruby-auth-check-404-on-compute into 2924980 on google:master.

coveralls commented Apr 23, 2015

Coverage increased (+0.03%) to 99.27% when pulling fe1c46c on tbetbetbe:ruby-auth-check-404-on-compute into 2924980 on google:master.

1 similar comment

coveralls commented Apr 23, 2015

Coverage increased (+0.03%) to 99.27% when pulling fe1c46c on tbetbetbe:ruby-auth-check-404-on-compute into 2924980 on google:master.

sqrrrl added a commit that referenced this pull request


          Merge pull request #25 from tbetbetbe/ruby-auth-check-404-on-compute

b5ff47f

Adds more robust checking of the status code during compute engine auth.

sqrrrl merged commit b5ff47f into googleapis:master

tbetbetbe deleted the ruby-auth-check-404-on-compute branch

August 6, 2015 19:20

google-admin unassigned sqrrrl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet