Avoid nullability compiler/clang-tidy warnings in _GTMDevAssert. #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The string parameters in NSAssertionHandler's -handleFailureInFunction:… method are declared nonnull, but converting __PRETTY_FUNCTION__ and __FILE__ to NSString (via +[NSString stringWithUTF8String:] returns nullable, leading to warnings.
thomasvl
reviewed
Jan 21, 2020
thomasvl
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string parameters in NSAssertionHandler's -handleFailureInFunction:… method are declared nonnull, but converting PRETTY_FUNCTION and FILE to NSString (via +[NSString stringWithUTF8String:] returns nullable, leading to warnings.
I don't know of any reason PRETTY_FUNCTION or FILE would ever fail to convert to UTF-8, but this deals with the warnings by explicitly handling the nil return case from stringWithUTF8String: by providing a static string.
Also adds a __builtin_expect() around the condition, as the intention is that the condition should never be true.