Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.ac not properly compiling pthreads support into googletest #2162

Closed
ngie-eign opened this issue Mar 3, 2019 · 1 comment
Closed

Comments

@ngie-eign
Copy link
Contributor

As I described in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236169, googletest 1.8.1, compiled from ports, is not properly enabling pthread support in libgtest, due to an interesting set of assumptions made by googletest/m4/acx_pthread.m4, in terms of how arguments are passed to the clang compiler/linker. This might be triggered by clang++ incompatibilities with g++.

This is forcing some end-users of googletest to have to link libpthread support in after this fact, which is superfluous and unnecessary. FreeBSD is one example of this.

Please see the FreeBSD bug for more details.

CC: @asomers

@ngie-eign
Copy link
Contributor Author

This is no longer an issue since the build systems supported are only bazel and cmake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant