Remove custom implementations of std::remove_reference #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
263417291 |
|
It looks like we need to do some internal cleanup to get this working. I'll get that started and update when we're ready to merge this. |
|
Ok, thanks! The problem here is all these type traits either depend on each other or were defined in similar places. |
kuzkry
force-pushed
the
custom-type-traits-remove_reference
branch
from
efaf9e4
to
69651d1
Compare
kuzkry
force-pushed
the
custom-type-traits-remove_reference
branch
2 times, most recently
from
f429c48
to
366e34c
Compare
|
Retriggering CI |
kuzkry
force-pushed
the
custom-type-traits-remove_reference
branch
from
366e34c
to
62f4b03
Compare
kuzkry
force-pushed
the
custom-type-traits-remove_reference
branch
from
62f4b03
to
5d7cdbb
Compare
rogeeff
pushed a commit
that referenced
this pull request
Sep 6, 2019
kuzkry
added a commit
to kuzkry/googletest
that referenced
this pull request
Sep 7, 2019
ab8f346 is a manual merge and it abandoned some things from PR google#2395.
kuzkry
added a commit
to kuzkry/googletest
that referenced
this pull request
Sep 7, 2019
This fixes up ab8f346 (a manual merge) that has abandoned some things from PR google#2395.
kuzkry
added a commit
to kuzkry/googletest
that referenced
this pull request
Sep 16, 2019
This fixes up ab8f346 (a manual merge) that has abandoned some things from PR google#2395.
thejcannon
pushed a commit
to thejcannon/googletest
that referenced
this pull request
Oct 23, 2019
This fixes up ab8f346 (a manual merge) that has abandoned some things from PR google#2395.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2392