Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge stuff that has been given up by manual merges #2448

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

kuzkry
Copy link
Contributor

@kuzkry kuzkry commented Sep 7, 2019

Leftovers from improperly closed manual reviews.

This fixes up ab8f346 (a manual merge) that has abandoned some things
from PR google#2395.
This fixes up f2fb48c (a manual merge) that has abandoned some things
from PR google#2407.
@kuzkry kuzkry changed the title Merge stuff that has been given up by manual merge Merge stuff that has been given up by manual merges Sep 16, 2019
@gennadiycivil
Copy link
Contributor

273570181
Thank you, we have started internal review. Please don't push any more changes into this PR as they might be overwritten.

This happens sometimes because the SoT for the development is internal and the process is not ideal.
We are incrementally working to make sure this does not happen again

@kuzkry
Copy link
Contributor Author

kuzkry commented Oct 8, 2019

@gennadiycivil, I realised that some time ago :) But it's nice you started warning people about it.

@gennadiycivil
Copy link
Contributor

@gennadiycivil, I realised that some time ago :) But it's nice you started warning people about it.
Ah, this would be the "incrementally working" part :-)

gennadiycivil added a commit that referenced this pull request Oct 10, 2019
@gennadiycivil gennadiycivil merged commit 3339b97 into google:master Oct 10, 2019
@kuzkry kuzkry deleted the bad-googletest-export branch October 10, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants