Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with 7.13 version #146

Closed
sassiwalid opened this issue Mar 4, 2024 · 15 comments
Closed

issue with 7.13 version #146

sassiwalid opened this issue Mar 4, 2024 · 15 comments
Assignees

Comments

@sassiwalid
Copy link

Hello I think that the 7.13 version has an issue with the Privacy dependency

error: module name "GoogleUtilities-Privacy" is not a valid identifier

which block the upload symbols on Apple platform. Can you please resolve this issue of naming.

regards

@ncooke3
Copy link
Member

ncooke3 commented Mar 4, 2024

Hi @sassiwalid, is this error appearing when trying to upload to the App Store? If so, which Xcode version are you using?

@ncooke3 ncooke3 self-assigned this Mar 4, 2024
@sassiwalid
Copy link
Author

yes when we upload to the App Store (Test flight). We use Xcode 15.2 :)

@ncooke3
Copy link
Member

ncooke3 commented Mar 4, 2024

@sassiwalid, can you reproduce the issue when selecting Validate App (I've circled the button in the top right of the below image)?

Screenshot 2024-03-04 at 1 01 13 PM

@sassiwalid
Copy link
Author

I have validate using the 7.12 or 7.11.5 version using the organizer, no problem but when I launch the CI/CD with the 7.13 version I got the error above

@ncooke3
Copy link
Member

ncooke3 commented Mar 4, 2024

Interesting, thanks. I wasn't able to reproduce this while validating on Xcode 15.1, Xcode 15.2, or Xcode 15.3. Could you please try validating the 7.13.0 version using the organizer? I'm still trying to narrow down the scope of the issue. I suspect the cause lies in the target containing resources and a dash in its name.

@sassiwalid
Copy link
Author

Really very strange with organizer upload and the 7.13 version the upload work
Capture d’écran 2024-03-04 à 20 46 02

But on CI/CD they still not work with the 7.13

@ncooke3
Copy link
Member

ncooke3 commented Mar 4, 2024

Hi @sassiwalid, I presume your project is using GoogleUtilities via a dependency on Firebase. What version of Firebase are you using? I have a potential fix that I could include in a branch off of the Firebase version you are using so you can test it out.

@sassiwalid
Copy link
Author

Hello @ncooke3 we use firebase version 10.1.0, and yes under the hood firebase load GoogleUtilities as you have mentioned.

@ncooke3
Copy link
Member

ncooke3 commented Mar 5, 2024

Hi @sassiwali, I published a point release 7.13.1 with a fix that hopefully will unblock you. Could you please try pulling this new GoogleUtilities version?

@sassiwalid
Copy link
Author

Yes I will check now

@ncooke3
Copy link
Member

ncooke3 commented Mar 6, 2024

Hi @MinceMan, I believe this issue is for a different issue. Feel free to open another issue in this repo, but firebase/firebase-ios-sdk#12458 should be sufficient to cover this repo.


Hi @sassiwalid, I'm going to close this. LMK if the issue still persists and I can re-open.

@Neusoft-Songtn
Copy link

Hello, I saw that the author released release 7.13.1 to solve the above problems, but it seems that the version on Cocoapods platform has not been updated. Our App uses pod for integration, can we update the pod version to 7.13.1? Thank you very much

@ncooke3 ncooke3 closed this as completed Mar 22, 2024
@ncooke3
Copy link
Member

ncooke3 commented Mar 22, 2024

Hi @Neusoft-Songtn, this issue was with Swift Package Manager so there was no CocoaPods release for 7.13.1

@sassiwalid
Copy link
Author

Hello @ncooke3 thank you sorry I'm very late to respond to you. Now it's work great on Ci CD with the last version 7.13.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants