Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move lib/grinder_***.dart libs to lib/src #205

Closed
seaneagan opened this issue Apr 23, 2015 · 0 comments
Closed

Move lib/grinder_***.dart libs to lib/src #205

seaneagan opened this issue Apr 23, 2015 · 0 comments
Milestone

Comments

@seaneagan
Copy link
Contributor

They are already exported by lib/grinder.dart, so the only use case for them would be someone want to pull them in without pulling in all of grinder, but we'd need to think more about how to divide up the functionality before officially supporting those libs, and just using show / hide on a lib/grinder.dart import seems sufficient.

This is technically a breaking change, but we haven't advertised these libs at all, so I expect no one is actually importing them directly.

@seaneagan seaneagan added this to the 0.7.1 milestone Apr 23, 2015
@devoncarew devoncarew modified the milestones: 0.7.1, 0.7.2 May 18, 2015
jcollins-g pushed a commit to jcollins-g/grinder.dart that referenced this issue Feb 12, 2021
This treats wrapped cascades like other wrapped expressions. At the
same time, it adds support for expression nesting to increase
indentation by values other than +4.

Fix google#200. Fix google#203. Fix google#205. Fix google#221. Fix google#236.

R=pquitslund@google.com

Review URL: https://chromiumcodereview.appspot.com//1187663002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants