Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-format some files #236

Merged
merged 1 commit into from May 16, 2015
Merged

re-format some files #236

merged 1 commit into from May 16, 2015

Conversation

devoncarew
Copy link
Contributor

Add some manual directives to the formater to improve method decl formatting.

@zoechi @seaneagan

devoncarew added a commit that referenced this pull request May 16, 2015
@devoncarew
Merge pull request #236 from google/devoncarew_more_dartfmt
187c8a3 
re-format some files
@devoncarew devoncarew merged commit 187c8a3 into master May 16, 2015
@zoechi
Copy link

zoechi commented May 16, 2015

LGTM.
I gave up teaching dartformat ;-)
At the beginning I tried to convince Bob to support annotations to be able to tell dartformat to not format parts of the code.
dartformat formats most of the code perfect and a few things not perfect but still acceptable, and all this without any cost. In overall quite a good deal.

@devoncarew devoncarew deleted the devoncarew_more_dartfmt branch June 11, 2015 21:23
jcollins-g pushed a commit to jcollins-g/grinder.dart that referenced this pull request Feb 12, 2021
@munificent
Nest cascades like expressions but indent them like blocks.
61e60cb 
This treats wrapped cascades like other wrapped expressions. At the
same time, it adds support for expression nesting to increase
indentation by values other than +4.

Fix google#200. Fix google#203. Fix google#205. Fix google#221. Fix google#236.

R=pquitslund@google.com

Review URL: https://chromiumcodereview.appspot.com//1187663002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devoncarew @zoechi