Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor file names, location, and contents #200

Merged
merged 2 commits into from Apr 22, 2015

Conversation

devoncarew
Copy link
Contributor

  • Move all the sdk related code from grinder_tools to grinder_sdk.dart
  • rationalize our test dir layout a bit
  • add some tests for things in grinder_tools

This is meant to be entirely w/o user impact, just some project hygiene. No changes to code (modulo some new tests).

@seaneagan

@seaneagan
Copy link
Contributor

Removing stuff from grinder_tools.dart is technically a breaking change. Not sure if anyone is actually importing that library, but since it's just in lib rather than lib/src, it's fair game for them to. I'm not sure we need any of the lib/grinder_***.dart libraries (including grinder_sdk.dart in this PR), since we already export them from lib/grinder.dart. If we did keep them I think the grinder_ prefix is redundant.

I personally like to have small libraries under lib/src which import each other as needed. Then just export any public APIs from those in lib/grinder.dart.

@devoncarew
Copy link
Contributor Author

Removing stuff from grinder_tools.dart is technically a breaking change.

Totally, but my guess is that most people are just importing only grinder.dart, esp. as that exports the other public libs. I'm comfortable with assuming the small change that we break a consumer to get the benefit of rev'ing the major semver fewer times (which has it's own cost downstream).

devoncarew added a commit that referenced this pull request Apr 22, 2015
refactor file names, location, and contents
@devoncarew devoncarew merged commit 982c59a into master Apr 22, 2015
@devoncarew devoncarew deleted the devoncarew_file_refactoring branch April 23, 2015 21:18
jcollins-g pushed a commit to jcollins-g/grinder.dart that referenced this pull request Feb 12, 2021
This treats wrapped cascades like other wrapped expressions. At the
same time, it adds support for expression nesting to increase
indentation by values other than +4.

Fix google#200. Fix google#203. Fix google#205. Fix google#221. Fix google#236.

R=pquitslund@google.com

Review URL: https://chromiumcodereview.appspot.com//1187663002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants