Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOI Editor] Importing LOIs for new unpublished job will end up having unassociated LOIs if user end up not publishing the job #1964

Closed
DaoyuT opened this issue Aug 9, 2024 · 2 comments
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@DaoyuT
Copy link
Contributor

DaoyuT commented Aug 9, 2024

For bug #1714, we did a quicker fix #1958 that shows LOIs imported for new unpublished job. However, if user don't publish the job after importing LOIs, those LOIs would still exist with no job associated to it. Although they won't be rendered in the map view since they don't belong to any valid job, it's still bad to have these useless data sitting in the database.

One solution is to delete these LOIs that don't belong to any valid job every time the user hits the publish button.
On top of that we could also bundle the import/delete LOI action within the publish job action, like mentioned in bug #1714.

@jcqli
Copy link

jcqli commented Aug 12, 2024

Copying over more info from #1895:

When LOIs are imported for a job that is not published, they do not show up in the map as they are not associated with any jobs.

We can bundle the import/delete LOI action within the publish job action:

  • Add a state to each LOI and manage the states so that in the edit job phase
  • user import LOIs, LOIs shows in edit page, user clicks publish button => LOIs shows in map page
  • user import LOIs, LOIs shows in edit page, user quits editing without clicking publish => LOIs does not show in map page
  • user delete LOIs, LOIs does not show in edit page, user clicks publish button => LOIs does not show in map page
  • user delete LOIs, LOIs does not show in edit page, user quits editing without clicking publish => LOIs shows in map page
  • Same behavior should happen to a new unpublished job

More context: #1714 (comment)

@rfontanarosa rfontanarosa self-assigned this Sep 10, 2024
@kenstershiro kenstershiro added the for pm/ux review Product decision needed label Oct 11, 2024
@kenstershiro
Copy link
Collaborator

From @rfontanarosa - this should be solved now when you click publish they get cleaned up

@kenstershiro kenstershiro removed the for pm/ux review Product decision needed label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants