We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently Gson.assertFullConsumption throws a JsonIOException if the JSON was not fully consumed:
Gson.assertFullConsumption
JsonIOException
gson/gson/src/main/java/com/google/gson/Gson.java
Lines 902 to 906 in ceae88b
Maybe it would be better to throw a JsonSyntaxException instead, because:
JsonSyntaxException
IOException
fromJson(String, ...)
For the case where a type adapter is not properly consuming all input (see also #835) neither would match perfectly though that might be acceptable.
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Currently
Gson.assertFullConsumption
throws aJsonIOException
if the JSON was not fully consumed:gson/gson/src/main/java/com/google/gson/Gson.java
Lines 902 to 906 in ceae88b
Maybe it would be better to throw a
JsonSyntaxException
instead, because:IOException
was thrown)fromJson(String, ...)
which does not declare that it can throw aJsonIOException
For the case where a type adapter is not properly consuming all input (see also #835) neither would match perfectly though that might be acceptable.
The text was updated successfully, but these errors were encountered: