feat!: prefer single quotes if possible, raising warning #475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn if single quotes are not used in a situation in which this is possible. see: https://eslint.org/docs/rules/quotes
This rule lets us catch the behavior discussed here, in which a template string is used with no replacements.
I've opted for a warning rather than an error, as in testing it seemed like this rule could be a bit disruptive for folks who write strings like this:
as it requires the replacement:
fixes: googleapis/google-cloud-node#2915