Skip to content

Commit

Permalink
Fully remove GWT-RPC support externally.
Browse files Browse the repository at this point in the history
Really, really closes #3680.

Possible future work:
- Be consistent about whether we put @GwtCompatible on the remaining internal CustomFieldSerializer classes. (For those files, it probably acts only as documentation (of something that is pretty obvious :)). Our open-source build used to take action when it saw `@GwtCompatible(emulated=true)`, but (a) it doesn't anymore, (b) those files don't exist externally anymore, and (c) they weren't `emulated=true` :) I believe that our internal build requires @GwtCompatible on most files in our GWT target, but I think there's an exception for GWT-target-only sources.)
- Remove some of the GwtSerializationDependencies classes. However, some of these classe are set up as *supertypes* of our prod classes, so this would require some surgery. Keeping them is harmless: It doesn't actually make the classes GWT-serializable.
- Remove the usages of serializable=true on @GwtCompatible, at least externally but maybe just entirely.

RELNOTES=[Guava types can no longer be sent over GWT-RPC.](https://groups.google.com/d/msg/guava-announce/zHZTFg7YF3o/rQNnwdHeEwAJ) Even the earlier, temporary way to reenable support (`guava.gwt.emergency_reenable_rpc`) no longer has an effect.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=334598649
  • Loading branch information
cpovirk authored and kluever committed Oct 1, 2020
1 parent 7f164ef commit 0cb89dd
Show file tree
Hide file tree
Showing 65 changed files with 0 additions and 3,052 deletions.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit 0cb89dd

Please sign in to comment.