Store values in a local first instead of repeatedly reading it from…

… a field. At worst, this is a no-op. At best, it may perform better. RELNOTES=n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=301180270
google · Mar 16, 2020 · 9ee6997 · 9ee6997
1 parent bfacdb0
commit 9ee6997
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/android/guava/src/com/google/common/util/concurrent/CollectionFuture.java b/android/guava/src/com/google/common/util/concurrent/CollectionFuture.java
@@ -41,7 +41,7 @@ abstract class CollectionFuture<V, C> extends AggregateFuture<V, C> {
       boolean allMustSucceed) {
     super(futures, allMustSucceed, true);
 
-    this.values =
+    List<Present<V>> values =
         futures.isEmpty()
             ? ImmutableList.<Present<V>>of()
             : Lists.<Present<V>>newArrayListWithCapacity(futures.size());
@@ -50,6 +50,8 @@ abstract class CollectionFuture<V, C> extends AggregateFuture<V, C> {
     for (int i = 0; i < futures.size(); ++i) {
       values.add(null);
     }
+
+    this.values = values;
   }
 
   @Override

diff --git a/guava/src/com/google/common/util/concurrent/CollectionFuture.java b/guava/src/com/google/common/util/concurrent/CollectionFuture.java
@@ -41,7 +41,7 @@ abstract class CollectionFuture<V, C> extends AggregateFuture<V, C> {
       boolean allMustSucceed) {
     super(futures, allMustSucceed, true);
 
-    this.values =
+    List<Present<V>> values =
         futures.isEmpty()
             ? ImmutableList.<Present<V>>of()
             : Lists.<Present<V>>newArrayListWithCapacity(futures.size());
@@ -50,6 +50,8 @@ abstract class CollectionFuture<V, C> extends AggregateFuture<V, C> {
     for (int i = 0; i < futures.size(); ++i) {
       values.add(null);
     }
+
+    this.values = values;
   }
 
   @Override