Skip to content

Commit

Permalink
Fix Javadoc breakage under JDK11 canary.
Browse files Browse the repository at this point in the history
  • Loading branch information
cpovirk authored and ronshapiro committed Feb 26, 2019
1 parent f4ed20e commit ed3ba07
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions android/guava/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@
<!-- (We need JDK *sources*, not just -link, so that {@inheritDoc} works.) -->
<sourcepath>${project.build.sourceDirectory}:${project.build.directory}/jdk-sources</sourcepath>

<subpackages>com.google.common</subpackages>
<excludePackageNames>com.google.common.base.internal</excludePackageNames>
<!-- Passing `-subpackages com.google.common` breaks things, so we explicitly exclude everything else instead. -->
<excludePackageNames>com.google.common.base.internal,com.google.thirdparty.publicsuffix,com.oracle,com.sun,java,javax,jdk,org,sun</excludePackageNames>

<!-- TODO(cpovirk): Move this to the parent after making the package-list files available there. -->
<!-- We add the link ourselves, both so that we can choose Java 9 over the version that -source suggests and so that we can solve the JSR305 problem described below. -->
Expand Down
1 change: 1 addition & 0 deletions android/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@
<additionalOption>-Xdoclint:-html</additionalOption>
</additionalOptions>
<linksource>true</linksource>
<source>8</source>
</configuration>
<executions>
<execution>
Expand Down
4 changes: 2 additions & 2 deletions guava/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@
<!-- (We need JDK *sources*, not just -link, so that {@inheritDoc} works.) -->
<sourcepath>${project.build.sourceDirectory}:${project.build.directory}/jdk-sources</sourcepath>

<subpackages>com.google.common</subpackages>
<excludePackageNames>com.google.common.base.internal</excludePackageNames>
<!-- Passing `-subpackages com.google.common` breaks things, so we explicitly exclude everything else instead. -->
<excludePackageNames>com.google.common.base.internal,com.google.thirdparty.publicsuffix,com.oracle,com.sun,java,javax,jdk,org,sun</excludePackageNames>

<!-- TODO(cpovirk): Move this to the parent after making the package-list files available there. -->
<!-- We add the link ourselves, both so that we can choose Java 9 over the version that -source suggests and so that we can solve the JSR305 problem described below. -->
Expand Down
1 change: 1 addition & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@
<additionalOption>-Xdoclint:-html</additionalOption>
</additionalOptions>
<linksource>true</linksource>
<source>8</source>
</configuration>
<executions>
<execution>
Expand Down

0 comments on commit ed3ba07

Please sign in to comment.