Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RegularContiguousSet.intersection to handle singleton results. #2197

Closed
wants to merge 3 commits into from
Closed

Fix RegularContiguousSet.intersection to handle singleton results. #2197

wants to merge 3 commits into from

Conversation

perceptron8
Copy link
Contributor

Fixes #2196.

@perceptron8
Copy link
Contributor Author

oraclejdk7 and openjdk7 builds fail with:

The log length has exceeded the limit of 4 Megabytes (this usually means that test suite is raising the same exception over and over).

The build has been terminated.

It doesn't seem to be related to this PR.

oraclejdk8 build completes with:

Done. Your build exited with 0.

If there's something else I can do, let me know.

@cgdecker
Copy link
Member

The current build failure is an issue with the latest GWT 2.8.0 snapshot, which I reported over here: gwtproject/gwt#9206

@lowasser
Copy link
Contributor

This fix LGTM once the test issues are resolved.

@perceptron8
Copy link
Contributor Author

I saw that gwtproject/gwt#9206 seems to be resolved.

Could someone restart following builds, please?

I'd like to avoid pushing commits just to trigger rebuild.

@perceptron8
Copy link
Contributor Author

The last commit is not related to intersection - I hope you will find it valuable, however. I found that some assertions were too weak.

@cgdecker Thanks for restarting builds!

@cpovirk cpovirk self-assigned this Oct 23, 2015
cpovirk pushed a commit that referenced this pull request Oct 23, 2015
@perceptron8 @cpovirk
Fix RegularContiguousSet.intersection to handle singleton results.
44a2592 
Pull request from perceptron8 <perceptron8@gmail.com>
#2197

Fixes #2196
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=106153276
@cpovirk cpovirk closed this Oct 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cpovirk cpovirk

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@perceptron8 @cgdecker @lowasser @cpovirk @googlebot