-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In MapSplitter, ignore key-value separator after first #2663
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
anyone can take a look? |
@jiafu1115 Should this regard different types of splitters? Or add some method like |
@liach no. only change the inner behavior for MapSplitter. This is the simplest way to meet requirement.WDYT?Thanks |
There must be a reason why it throws an exception when detecting more than one separators. You should ping a project manager. |
I think we need to ping the authors of |
@liach Thanks for your reminder. We may need to wait and wait and wait...... |
@eamonnmcmanus Thanks for your change for title, it is more clear now. |
@raghsriniv can you help to review it? thanks |
It is one important issue need to be fixed to support most cases which values may contain the separator.
for one example:
I can make sure my key can't contain separator. but I can't make sure my value can't contain separator due to the value is generated by third-part service or special codec which can get separator. So I think we should fix this issue. It is common issue for most of case, Throwing IAE isn't reasonable or easier to let's happen low rating bug.
Can someone help to take a look at this PR. Thanks.