Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moe Sync #3312

Merged
merged 2 commits into from Nov 6, 2018
Merged

Moe Sync #3312

merged 2 commits into from Nov 6, 2018

Conversation

ronshapiro
Copy link
Contributor

@ronshapiro ronshapiro commented Nov 6, 2018

This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.

Commits:

Add MediaType.MICROSOFT_OUTLOOK and add missing javadocs to a few other MediaTypes.

Closes #3309

522d3aa


Use maven-compiler-plugin version 3.8.0.

Closes #3294.

f31bf94

Tomschi and others added 2 commits November 6, 2018 15:40
…er MediaTypes.

See #3309

RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=219797217
See #3294.

RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=219835316
@ronshapiro ronshapiro added the internal-sync A PR that represents a push from Google's internal repo label Nov 6, 2018
@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot
Copy link
Collaborator

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@ronshapiro ronshapiro merged commit c367e94 into master Nov 6, 2018
@ronshapiro ronshapiro deleted the sync-master-2018/11/06 branch November 6, 2018 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes internal-sync A PR that represents a push from Google's internal repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants