Declare the V parameter of toTable as non-nullable.
#7077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
...on account of [how it is](https://github.com/google/guava/blob/a6a34dc42627f2dc5b8937f428322739b74ce8f3/guava/src/com/google/common/collect/TableCollectors.java#L206). I noticed this during cl/611440623, and I just wrote a bit about `Preconditions.checkNotNull` in some extremely post-submit commentary on cl/372346107. RELNOTES=n/a PiperOrigin-RevId: 612591080
copybara-service
bot
force-pushed
the
test_612437623
branch
from
14b1e76
to
5f77509
Compare
copybara-service
bot
closed this pull request by merging all changes
into
master
in
5f77509
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declare the
Vparameter oftoTableas non-nullable....on account of how it is.
I noticed this during cl/611440623, and I just wrote a bit about
Preconditions.checkNotNullin some extremely post-submit commentary on cl/372346107.RELNOTES=n/a