Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test "ElementwiseToAffine" support for ops with both tensor and scalar operands #534

Closed
AlexanderViand-Intel opened this issue Mar 15, 2024 · 1 comment · Fixed by #769
Closed
Labels
dialect: polynomial Issues concerning the polynomial dialect good first issue Good for newcomers

Comments

@AlexanderViand-Intel
Copy link
Collaborator

AlexanderViand-Intel commented Mar 15, 2024

The ElementwiseToLinalg pass in MLIR only supports operations where all operands are tensors and this requirement has been left in place for the ElementwiseToAffine pass. However, the reason that this limitation is necessary for the linalg version doesn't exist in the affine version, which should already support scalar operands as-is (well, after replacing the all_of in isElementwiseMappableOpOnRankedTensors with any_of) . However, polynomial operations have a SameOperandsAndResultType constraint, so to test whether this feature actually works as expected, we'd need to either allow mixed tensor-scalar operations and/or simply test this pass with a different ElementwiseMappable op.

Copy link

This issue has 1 outstanding TODOs:

This comment was autogenerated by todo-backlinks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialect: polynomial Issues concerning the polynomial dialect good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants