-
Notifications
You must be signed in to change notification settings - Fork 122
Set Reminder frontend - Fixes #158 #1232
Conversation
@crhym3 am I doing anything with |
Monica said:
That's why I created |
This goes through the signin+enable notification flow. I was thinking the backend could do the bit where it sends a notification the day before the keynote session starts. |
Ah, yeah that could work! But I thought you also needed a data bit What if I don't want to be notified 1 day before but only when keynote starts. Is that a valid user case? |
The code looks good. It's kind of a shame that a bunch of the code from Re: |
@jeffposnick and I talked. We're just going to hook this up to the |
Set Reminder frontend - Fixes #158
If this will be triggered by the keynote, then this is redundant as we're already sending notifications for the keynote to everyone who is opted-in to receive notifications. Can't we just time base this notification for May 27? also, just a reminder that the keynote notification should happen at 9:20am vs 8:50am (as originally planned). |
(unless something has changed and we're no longer adding keynote by default to my schedule?) |
We discussed (#158 (comment)) leaving this as an additional path for opting into notifications. Users won't get a notification for anything unless they through that flow. |
right - we discussed having "Set a reminder" for the day before since we already have a reminder by default for the keynote (and as an extra reminder to turn on notifications). But per this thread, it seems you want "Set a reminder" to be associated with the Keynote instead? (which i don't agree with, since it's redundant for the users!) |
We still need users to opt-in to notifications so it's not entirely Eng chatted about this this morning. We all agreed that it's better to err Keeping it to the keynote is the easiest solution and is already On Wed, Apr 29, 2015 at 9:48 PM Monica Bagagem notifications@github.com
|
I would rather have these as 2 separate reminders but if everyone agrees that this makes sense to associate with the keynote one, then we should send it perhaps 30 min before at 9am (to give people some time)? What does it say currently: |
I just created #1248 to track notifications for sessions starting (including the keynote), tied to Phase 3. |
Thanks Jeff On Thu, Apr 30, 2015 at 10:26 AM Jeffrey Posnick notifications@github.com
|
don't forget the videos!
|
I won't forget the videos! But I mean, that's what, Phase 4? Who can think that far ahead? 😄 |
It's actually Phase 2, once DevBytes start being released (i.e. before I/O!)
|
Ah, okay. Let me track that in a separate issue then. |
Actually, are we showing notifications for videos that aren't tied to sessions? I thought we scrapped that because there's no way to opt-in for a random DevByte notification, and we were only going to notify you when a session in My Schedule had its video published. |
Ah yes, for notifications this only impacts P4! |
R: @jeffposnick @crhym3 @brendankenny