Set Reminder frontend - Fixes #158

[ebidel]

R: @jeffposnick @crhym3 @brendankenny

[ebidel]

@crhym3 am I doing anything with iostart or is that @jeffposnick ?

[x1ddos]

Monica said:

"Set a reminder" should add a separate reminder for the beginning of I/O, which is actually at 9am with a pre-Keynote show. When a user sets a reminder for I/O tho, ideally, they will see a notification the day before letting them know I/O is starting soon.

That's why I created iostart. AFAIU #158 should be done in a way similar to what "I want to receive notifications" checkbox in the signin settings does, calling PUT /api/v1/user/notify.

[ebidel]

This goes through the signin+enable notification flow. I was thinking the backend could do the bit where it sends a notification the day before the keynote session starts.

[x1ddos]

Ah, yeah that could work! But I thought you also needed a data bit iostart to reflect this in the UI?

What if I don't want to be notified 1 day before but only when keynote starts. Is that a valid user case?

[jeffposnick]

The code looks good. It's kind of a shame that a bunch of the code from schedule.html needs to be copied over, but at the same time, there are a number of strings and variable bindings that would be messy to parameterize if the code were refactored into a helper function.

Re: iostart vs. __keynote__, I'm not sure either, and will discuss that bit with you all off-thread.

[ebidel]

@jeffposnick and I talked. We're just going to hook this up to the __keynote__ for now and allow uses to keep pressing the "set reminder" button. It will also help users if they open another browser and are not signed in. It will take them through that flow.

[monicabagagem]

If this will be triggered by the keynote, then this is redundant as we're already sending notifications for the keynote to everyone who is opted-in to receive notifications. Can't we just time base this notification for May 27?

also, just a reminder that the keynote notification should happen at 9:20am vs 8:50am (as originally planned).

[monicabagagem]

(unless something has changed and we're no longer adding keynote by default to my schedule?)

[ebidel]

We discussed (#158 (comment)) leaving this as an additional path for opting into notifications. Users won't get a notification for anything unless they through that flow.

[monicabagagem]

right - we discussed having "Set a reminder" for the day before since we already have a reminder by default for the keynote (and as an extra reminder to turn on notifications).

But per this thread, it seems you want "Set a reminder" to be associated with the Keynote instead? (which i don't agree with, since it's redundant for the users!)

[ebidel]

We still need users to opt-in to notifications so it's not entirely
redundant. Sign in prompts to enable the browser permission now, but it's
easy for users to dismiss that.

Eng chatted about this this morning. We all agreed that it's better to err
on the side of caution with notification stuff. Jeff made the point that
the last thing we want is to send dozens of notifications from now until
I/O, be too spammy, have users end up turning the feature off.

Keeping it to the keynote is the easiest solution and is already
implemented. We can still show this particular notification 24hrs before,
10min, or whatever we would like.

On Wed, Apr 29, 2015 at 9:48 PM Monica Bagagem notifications@github.com
wrote:

right - we discussed having "Set a reminder" for the day before since we
already have a reminder by default for the keynote (and as an extra
reminder to turn on notifications).

But per this thread it seems, you want "Set a reminder" to be associated
with the Keynote instead? (which i don't agree with, since it's redundant
for the users!)

—
Reply to this email directly or view it on GitHub
#1232 (comment)
.

[monicabagagem]

I would rather have these as 2 separate reminders but if everyone agrees that this makes sense to associate with the keynote one, then we should send it perhaps 30 min before at 9am (to give people some time)?

What does it say currently:
"The Google I/O keynote starts in 30 min" ---> prefered
OR
"The Google I/O keynote starts at 9AM PDT"

[ebidel]

@jeffposnick is that still a todo? https://github.com/GoogleChrome/ioweb2015/blob/master/app/scripts/shed/push-notifications.js#L128

[jeffposnick]

I just created #1248 to track notifications for sessions starting (including the keynote), tied to Phase 3.

[ebidel]

Thanks Jeff

On Thu, Apr 30, 2015 at 10:26 AM Jeffrey Posnick notifications@github.com
wrote:

I just created #1248
#1248 to track
notifications for sessions starting (including the keynote), tied to Phase
3.

—
Reply to this email directly or view it on GitHub
#1232 (comment)
.

[x1ddos]

don't forget the videos!
On 30 Apr 2015 7:39 pm, "Eric Bidelman" notifications@github.com wrote:

Thanks Jeff

On Thu, Apr 30, 2015 at 10:26 AM Jeffrey Posnick <notifications@github.com

wrote:

I just created #1248
#1248 to track
notifications for sessions starting (including the keynote), tied to
Phase
3.

—
Reply to this email directly or view it on GitHub
<
https://github.com/GoogleChrome/ioweb2015/pull/1232#issuecomment-97888336>
.

—
Reply to this email directly or view it on GitHub
#1232 (comment)
.

[jeffposnick]

I won't forget the videos! But I mean, that's what, Phase 4? Who can think that far ahead? 😄

[monicabagagem]

It's actually Phase 2, once DevBytes start being released (i.e. before I/O!)

[jeffposnick]

Ah, okay. Let me track that in a separate issue then.

[jeffposnick]

Actually, are we showing notifications for videos that aren't tied to sessions? I thought we scrapped that because there's no way to opt-in for a random DevByte notification, and we were only going to notify you when a session in My Schedule had its video published.

[monicabagagem]

Ah yes, for notifications this only impacts P4!
I was referring to the Video page, which needs to come out in P2.
We're all good!