Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Create notifications for "update: start" push events #1248

Closed
jeffposnick opened this issue Apr 30, 2015 · 4 comments
Closed

Create notifications for "update: start" push events #1248

jeffposnick opened this issue Apr 30, 2015 · 4 comments
Assignees
Milestone

Comments

@jeffposnick
Copy link
Contributor

In generateSessionNotification(), we're only currently creating notifications for "update: details" events, i.e. something about a session's metadata changed.

We need to add in logic that will display "update: start" notifications that are tied to the start of a session, including the keynote.

@x1ddos
Copy link
Contributor

x1ddos commented May 9, 2015

@jeffposnick if backend sends update: start for __keynote__ a day before, will you be able to distinguish between "io starts soon" and "session starts in 10 min"?

Maybe the best for sw is to look at the actual startTimestamp of the session and format the notification message accordingly?

@x1ddos
Copy link
Contributor

x1ddos commented May 9, 2015

Actually, @jeffposnick does it work for you if backend sent update: start and update: soon, where soon means like 1 day before? You can also check startTimestamp to get exact timing anyway.

It would be cool, I think, if you displayed "X session starts in Y minutes" for update: start, where Y is calculated at the time you're processing updates in the sw, e.g. startTime - new Date().

x1ddos added a commit that referenced this issue May 10, 2015
x1ddos added a commit that referenced this issue May 10, 2015
@jeffposnick
Copy link
Contributor Author

I believe "X session starts in Y minutes" will be misleading for folks who don't see the notification right away.

We can hash out the wording details in the PR for the client-side changes.

@x1ddos
Copy link
Contributor

x1ddos commented May 11, 2015

yeah, it was just an idea.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants