SQL: add support for naming to ibis dialect #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on projections, I realized that I had not represented an obscure, but crucial component of the selection node. The selection node has a tuple field called
inputs. In this field the name of a projected column can be found, which is crucial to get the schema for the result right.This patch adds a list of names to the selection node in the ibis_dialect. I feel that
inputsrepresents things that are already represented by other parts of the selection node (like the table), so I decided not to mirror the field itself for the moment.This is the first patch in a series of patches aimed at broadening the project to represent Q6 of the tpc-h benchmark.