Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set tree_map = tree_multimap #5746

Closed
mattjj opened this issue Feb 17, 2021 · 4 comments
Closed

set tree_map = tree_multimap #5746

mattjj opened this issue Feb 17, 2021 · 4 comments
Assignees
@jakevdp
Labels
enhancement New feature or request

Comments

@mattjj
Copy link
Collaborator

mattjj commented Feb 17, 2021

Some users suggested that we should just set tree_map = tree_multimap in jax.tree_util. Seems reasonable! We can't think of a reason not to, so let's try it and see if anything breaks.
@mattjj mattjj added the enhancement New feature or request label Feb 17, 2021
@mattjj mattjj self-assigned this Feb 17, 2021
@jakevdp
Copy link
Collaborator

jakevdp commented Jun 17, 2021

Done in #6585

@jakevdp jakevdp closed this as completed Jun 17, 2021
@carlosgmartin
Copy link
Contributor

@jakevdp @mattjj Since these functions have been unified, should the docs be updated to reference only tree_map to avoid confusion? Perhaps a deprecation warning should be added to tree_multimap?

@jakevdp
Copy link
Collaborator

jakevdp commented Mar 31, 2022

Yes, those are good ideas!

@jakevdp jakevdp reopened this Mar 31, 2022
@jakevdp jakevdp assigned jakevdp and unassigned mattjj Mar 31, 2022
@jakevdp jakevdp mentioned this issue Apr 1, 2022
Merged
@jakevdp
Copy link
Collaborator

jakevdp commented May 23, 2022

Remaining TODO: remove deprecated tree_multimap function after July 1, 2022, in accordance with the API Compatibility Policy.

@jakevdp jakevdp mentioned this issue Jul 6, 2022
Merged
@jakevdp jakevdp closed this as completed Jul 26, 2022
@jackgoffinet jackgoffinet mentioned this issue Oct 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakevdp jakevdp

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jakevdp @mattjj @carlosgmartin