Fixed issue with complex-valued inputs to LOBPCG #14005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alg.lobpcg_standard
|
Sorry we lost track of this - looks great! Do you think you could add a test covering the new behavior? The best place would probably be in http://go/jax-github/blob/main/tests/lobpcg_test.py Thanks! |
|
I've been a bit busy the last few days, but should have time for that later this week! |
|
Thanks, no problem. Let me know if there's any way I can help! |
|
It looks like this has gone stale – I'm going to close it. Feel free to re-open if you're still interested in working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this issue with
jax.experimental.sparse.linalg.lobpcg_standardcrashing when complex dtypes are used. This is my first JAX PR, so please let me know if this is missing anything 😄