Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prototool linting and formatting #1105

merged 7 commits into from Nov 8, 2018

prototool linting and formatting #1105

merged 7 commits into from Nov 8, 2018


Copy link

@gdbelvin gdbelvin commented Nov 8, 2018

brew install prototool
prototool lint
prototool format -w
@gdbelvin gdbelvin requested a review from jtoohill Nov 8, 2018
@gdbelvin gdbelvin added this to In progress in API Update Hackathon via automation Nov 8, 2018
gdbelvin added 2 commits Nov 8, 2018
* master:
  API: Rename Epoch to Revision (#1104)
@gdbelvin gdbelvin force-pushed the gdbelvin:prototool branch from 7fddac9 to bf24ba7 Nov 8, 2018
Copy link

@codecov codecov bot commented Nov 8, 2018

Codecov Report

Merging #1105 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1105      +/-   ##
+ Coverage    67.2%   67.38%   +0.18%     
  Files          37       37              
  Lines        2680     2680              
+ Hits         1801     1806       +5     
+ Misses        577      574       -3     
+ Partials      302      300       -2
Impacted Files Coverage Δ
impl/sql/directory/storage.go 72.38% <0%> (+1.9%) ⬆️
core/keyserver/revisions.go 65.6% <0%> (+1.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 690d42f...7e49cad. Read the comment docs.

Copy link

@jtoohill jtoohill left a comment

I think you also need to regenerate the protos in the same commit

prototool.yaml Outdated Show resolved Hide resolved
gdbelvin added 3 commits Nov 8, 2018
Copy link
Contributor Author

@gdbelvin gdbelvin commented Nov 8, 2018

Fixed spacing and regenerated protos

@gdbelvin gdbelvin merged commit 3a91ee0 into google:master Nov 8, 2018
2 of 3 checks passed
2 of 3 checks passed
GolangCI Processing timeout
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
API Update Hackathon automation moved this from In progress to Done Nov 8, 2018
@gdbelvin gdbelvin deleted the gdbelvin:prototool branch Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.