Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

prototool linting and formatting #1105

Merged
merged 7 commits into from Nov 8, 2018
Merged

Conversation

gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin commented Nov 8, 2018

brew install prototool
prototool lint
prototool format -w

@gdbelvin gdbelvin added this to In progress in API Update Hackathon via automation Nov 8, 2018
@codecov
Copy link

codecov bot commented Nov 8, 2018

Codecov Report

Merging #1105 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1105      +/-   ##
==========================================
+ Coverage    67.2%   67.38%   +0.18%     
==========================================
  Files          37       37              
  Lines        2680     2680              
==========================================
+ Hits         1801     1806       +5     
+ Misses        577      574       -3     
+ Partials      302      300       -2
Impacted Files Coverage Δ
impl/sql/directory/storage.go 72.38% <0%> (+1.9%) ⬆️
core/keyserver/revisions.go 65.6% <0%> (+1.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 690d42f...7e49cad. Read the comment docs.

Copy link
Contributor

@jtoohill jtoohill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to regenerate the protos in the same commit

prototool.yaml Outdated Show resolved Hide resolved
@gdbelvin
Copy link
Contributor Author

gdbelvin commented Nov 8, 2018

Fixed spacing and regenerated protos

@gdbelvin gdbelvin merged commit 3a91ee0 into google:master Nov 8, 2018
API Update Hackathon automation moved this from In progress to Done Nov 8, 2018
@gdbelvin gdbelvin deleted the prototool branch November 8, 2018 23:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants