Increase concurrency of app and route reconcilers. #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the two big reconcilers we have which should experience the greatest amount of churn yet should still be relatively safe for increasing, the default number of goroutines handling is 2.
garethgeorge
approved these changes
Mar 24, 2023
garethgeorge
approved these changes
Mar 24, 2023
josephlewis42
added a commit
that referenced
this pull request
May 19, 2023
These are the two big reconcilers we have which should experience the greatest amount of churn yet should still be relatively safe for increasing, the default number of goroutines handling is 2. 10 is an arbitrary number but doesn't seem like it's too high.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the two big reconcilers we have which should experience the greatest amount of churn yet should still be relatively safe for increasing, the default number of goroutines handling is 2. 10 is an arbitrary number but doesn't seem like it's too high.