Fix runtime panic on LoadLicenses() #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may be possible that the amount of segments is lower than 3 which caused a runtime panic in the license loader. We now skip those paths to fix that issue. Found: https://github.com/cri-o/cri-o/runs/7037925519 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This was referenced Jun 24, 2022
saschagrunert
added a commit
to saschagrunert/bom
that referenced
this pull request
Jun 27, 2022
This reverts commit c1f1fa3 because of a runtime panic possibly fixed in google/licenseclassifier#44. Fixes to kubernetes-sigs#127 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
added a commit
to saschagrunert/bom
that referenced
this pull request
Jun 27, 2022
This reverts commit c1f1fa3 because of a runtime panic possibly fixed in google/licenseclassifier#44. Fixes kubernetes-sigs#127 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
|
This looks fine. As a rule, the distribution of files provided here won't include extra files that could trigger this issue, but I can see how it would be useful when loading files from other sources. Thanks! |
|
@wcn3 do you think we can create a new tag after this has been resolved? |
|
Just created v2.0.0-pre6 |
|
Thank you so much @wcn3! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be possible that the amount of segments is lower than 3 which caused a runtime panic in the license loader. We now skip those paths to fix that issue.
Found: https://github.com/cri-o/cri-o/runs/7037925519